Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(597)

Issue 2761733003: [Reading List iOS] Test WebState on JavaScript return. (Closed)

Created:
3 years, 9 months ago by Olivier
Modified:
3 years, 9 months ago
Reviewers:
jif
CC:
chromium-reviews, ios-reviews+chrome_chromium.org, ios-reviews_chromium.org, pkl (ping after 24h if needed), noyau+watch_chromium.org, marq+watch_chromium.org, stkhapugin, sdefresne+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Reading List iOS] Test WebState on JavaScript return. ContinuePageDistillation can be called on return from JavaScript call. WebState can be deleted (specially if there was an error). So test before dereferencing it. BUG=703102 Review-Url: https://codereview.chromium.org/2761733003 Cr-Commit-Position: refs/heads/master@{#458061} Committed: https://chromium.googlesource.com/chromium/src/+/aca5aa3e2873c888092bf83668286b515e891bfb

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M ios/chrome/browser/reading_list/reading_list_distiller_page.mm View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
Olivier
3 years, 9 months ago (2017-03-20 12:52:42 UTC) #3
jif
lgtm
3 years, 9 months ago (2017-03-20 14:25:44 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2761733003/1
3 years, 9 months ago (2017-03-20 14:26:43 UTC) #6
commit-bot: I haz the power
3 years, 9 months ago (2017-03-20 14:59:18 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/aca5aa3e2873c888092bf8366828...

Powered by Google App Engine
This is Rietveld 408576698