Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 2767143006: Remove null entries from UMA stats SharedPrefs (Closed)

Created:
3 years, 9 months ago by qinmin
Modified:
3 years, 9 months ago
CC:
chromium-reviews, asanka, agrieve+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove null entries from UMA stats SharedPrefs DownloadUmaStatsEntry.parseFromString() could potentially return null. And that null is added to the list in DownloadManagerService. This could potentially cause a crash. This CL avoids adding null to the list, and also fixes an error in parsing the string. BUG=704220 Review-Url: https://codereview.chromium.org/2767143006 Cr-Commit-Position: refs/heads/master@{#460026} Committed: https://chromium.googlesource.com/chromium/src/+/05a0df9c9908ceabcf5febca6daecb87dd1ae5f0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/download/DownloadManagerService.java View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/download/DownloadUmaStatsEntry.java View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (5 generated)
qinmin
PTAL
3 years, 9 months ago (2017-03-24 22:01:17 UTC) #3
qinmin
PTAL
3 years, 9 months ago (2017-03-24 22:01:18 UTC) #4
David Trainor- moved to gerrit
lgtm
3 years, 9 months ago (2017-03-28 03:06:52 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2767143006/1
3 years, 9 months ago (2017-03-28 05:32:53 UTC) #7
commit-bot: I haz the power
3 years, 9 months ago (2017-03-28 06:11:57 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/05a0df9c9908ceabcf5febca6dae...

Powered by Google App Engine
This is Rietveld 408576698