Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(771)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/download/DownloadManagerService.java

Issue 2767143006: Remove null entries from UMA stats SharedPrefs (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/download/DownloadUmaStatsEntry.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/download/DownloadManagerService.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadManagerService.java b/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadManagerService.java
index c1c51acf18d82e019be567aa41b6f162ad87d114..d70d04daea1d7e139a695b3fb1729cc266905c2c 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadManagerService.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadManagerService.java
@@ -1602,7 +1602,8 @@ public class DownloadManagerService extends BroadcastReceiver implements
Set<String> entries =
DownloadManagerService.getStoredDownloadInfo(mSharedPrefs, DOWNLOAD_UMA_ENTRY);
for (String entryString : entries) {
- mUmaEntries.add(DownloadUmaStatsEntry.parseFromString(entryString));
+ DownloadUmaStatsEntry entry = DownloadUmaStatsEntry.parseFromString(entryString);
+ if (entry != null) mUmaEntries.add(entry);
}
}
}
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/download/DownloadUmaStatsEntry.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698