Implement the BackgroundFetch{Fail,ed} Service Worker events

Implement the BackgroundFetch{Fail,ed} Service Worker events

This CL implements the two final events part of the Background Fetch
API: backgroundfetchfail and backgroundfetched. They'll be dispatched
from the BackgroundFetchEventDispatcher, through the
ServiceWorkerEventDispatcher, to the renderer, where they'll run.

The BackgroundFetchSettledFetch structure has been defined in the
SWEventDispatcher's mojom file, but will move to its more appropriate
location in Blink when the ServiceWorkerFetchRequest/Response types
have been migrated to Mojo proper. This is in-progress.

BUG=692534, 692581
Review-Url: https://codereview.chromium.org/2767093004
Cr-Commit-Position: refs/heads/master@{#459469}
Committed: https://chromium.googlesource.com/chromium/src/+/4b613c4cd7c83a70d4f176bcb6394b2a800bbd4d

[Peter Beverloo, 2017-03-23 19:16:00]

The CQ bit was checked by peter@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-23 19:16:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Peter Beverloo, 2017-03-23 19:23:38]

The CQ bit was checked by peter@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-23 19:23:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Peter Beverloo, 2017-03-23 20:00:25]

The CQ bit was checked by peter@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-23 20:00:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Peter Beverloo, 2017-03-23 20:03:40]

peter@chromium.org changed reviewers:
+ haraken@chromium.org, isherman@chromium.org, shimazu@chromium.org,
tsepez@chromium.org

[Peter Beverloo, 2017-03-23 20:03:40]

+shimazu for Service Workers (2 new events)
+haraken for Source/Web/
+tsepez for Mojo additions

    Note that Mojo-ifying the Request type has already
    started in the following CL:
    https://codereview.chromium.org/2762303002/

    The Response type has yet to follow.

+isherman for UMA

(fwiw, after the current CLs plus the Response mojofication I'll largely move
back to my own corners of the code again ^_^.)

[Ilya Sherman, 2017-03-23 20:08:42]

Metrics LGTM, thanks.

[commit-bot: I haz the power, 2017-03-23 20:28:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-23 20:28:28]

Dry run: Try jobs failed on following builders:
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Tom Sepez, 2017-03-23 20:40:27]

lgtm

[shimazu, 2017-03-24 00:19:27]

Just one comment:

https://codereview.chromium.org/2767093004/diff/60001/content/renderer/servic...
File content/renderer/service_worker/service_worker_context_client.cc (right):

https://codereview.chromium.org/2767093004/diff/60001/content/renderer/servic...
content/renderer/service_worker/service_worker_context_client.cc:223: //
response_time
Could you set the response time?

[Peter Beverloo, 2017-03-24 00:55:16]

https://codereview.chromium.org/2767093004/diff/60001/content/renderer/servic...
File content/renderer/service_worker/service_worker_context_client.cc (right):

https://codereview.chromium.org/2767093004/diff/60001/content/renderer/servic...
content/renderer/service_worker/service_worker_context_client.cc:223: //
response_time
On 2017/03/24 00:19:27, shimazu wrote:
> Could you set the response time?

Oops! Will do first thing tomorrow :)

[haraken, 2017-03-24 02:15:40]

WebKit LGTM

https://codereview.chromium.org/2767093004/diff/60001/third_party/WebKit/publ...
File
third_party/WebKit/public/platform/modules/background_fetch/WebBackgroundFetchSettledFetch.h
(right):

https://codereview.chromium.org/2767093004/diff/60001/third_party/WebKit/publ...
third_party/WebKit/public/platform/modules/background_fetch/WebBackgroundFetchSettledFetch.h:14:
// Represents a request/response pair for a settled Background Fetch fetch.

a settled Background Fetch.

[kinuko, 2017-03-24 03:40:02]

kinuko@chromium.org changed reviewers:
+ kinuko@chromium.org

[kinuko, 2017-03-24 03:40:03]

drive-by lgtm (trying to capture what's happening around)

https://codereview.chromium.org/2767093004/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/web/ServiceWorkerGlobalScopeProxy.cpp (right):

https://codereview.chromium.org/2767093004/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/web/ServiceWorkerGlobalScopeProxy.cpp:165:
workerGlobalScope()->scriptController()->getScriptState();
nit: you can reverse these lines to make the scope line shorter

[kinuko, 2017-03-24 03:40:24]

On 2017/03/24 03:40:03, kinuko wrote:
> drive-by lgtm (trying to capture what's happening around)

(After shimazu-san's comment is addressed)
 
>
https://codereview.chromium.org/2767093004/diff/60001/third_party/WebKit/Sour...
> File third_party/WebKit/Source/web/ServiceWorkerGlobalScopeProxy.cpp (right):
> 
>
https://codereview.chromium.org/2767093004/diff/60001/third_party/WebKit/Sour...
> third_party/WebKit/Source/web/ServiceWorkerGlobalScopeProxy.cpp:165:
> workerGlobalScope()->scriptController()->getScriptState();
> nit: you can reverse these lines to make the scope line shorter

[kinuko, 2017-03-24 04:04:00]

https://codereview.chromium.org/2767093004/diff/60001/content/renderer/servic...
File content/renderer/service_worker/service_worker_context_client.cc (right):

https://codereview.chromium.org/2767093004/diff/60001/content/renderer/servic...
content/renderer/service_worker/service_worker_context_client.cc:201:
blink::WebServiceWorkerResponse* web_response) {
How long do you expect before you remove this? If this might be around for a
while I prefer letting CacheStorageDispatcher::PopulateWebResponseFromResonse
use this method too

[Peter Beverloo, 2017-03-24 14:11:09]

Thank you - all done!

I'll put this on the CQ. Happy to migrate
CacheStorageDispatcher::PopulateWebResponseFromResonse over, although I suspect
that a week will be fine.

https://codereview.chromium.org/2767093004/diff/60001/content/renderer/servic...
File content/renderer/service_worker/service_worker_context_client.cc (right):

https://codereview.chromium.org/2767093004/diff/60001/content/renderer/servic...
content/renderer/service_worker/service_worker_context_client.cc:201:
blink::WebServiceWorkerResponse* web_response) {
On 2017/03/24 04:03:59, kinuko wrote:
> How long do you expect before you remove this? If this might be around for a
> while I prefer letting CacheStorageDispatcher::PopulateWebResponseFromResonse
> use this method too

Assuming we make progress on Mojofication of FetchAPIFrequest, FetchAPIResponse
should be much easier. My estimate would be next week.

https://codereview.chromium.org/2767093004/diff/60001/content/renderer/servic...
content/renderer/service_worker/service_worker_context_client.cc:223: //
response_time
On 2017/03/24 00:55:16, Peter Beverloo wrote:
> On 2017/03/24 00:19:27, shimazu wrote:
> > Could you set the response time?
> 
> Oops! Will do first thing tomorrow :)

Done.

https://codereview.chromium.org/2767093004/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/web/ServiceWorkerGlobalScopeProxy.cpp (right):

https://codereview.chromium.org/2767093004/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/web/ServiceWorkerGlobalScopeProxy.cpp:165:
workerGlobalScope()->scriptController()->getScriptState();
On 2017/03/24 03:40:03, kinuko wrote:
> nit: you can reverse these lines to make the scope line shorter

Done. Also in dispatchBackgroundFetchedEvent.

https://codereview.chromium.org/2767093004/diff/60001/third_party/WebKit/publ...
File
third_party/WebKit/public/platform/modules/background_fetch/WebBackgroundFetchSettledFetch.h
(right):

https://codereview.chromium.org/2767093004/diff/60001/third_party/WebKit/publ...
third_party/WebKit/public/platform/modules/background_fetch/WebBackgroundFetchSettledFetch.h:14:
// Represents a request/response pair for a settled Background Fetch fetch.
On 2017/03/24 02:15:40, haraken wrote:
> 
> a settled Background Fetch.

Done.

[Peter Beverloo, 2017-03-24 14:11:17]

The CQ bit was checked by peter@chromium.org

[Peter Beverloo, 2017-03-24 14:11:17]

The patchset sent to the CQ was uploaded after l-g-t-m from
haraken@chromium.org, tsepez@chromium.org, isherman@chromium.org,
kinuko@chromium.org
Link to the patchset: https://codereview.chromium.org/2767093004/#ps80001
(title: "Implement the BackgroundFetch{Fail,ed} Service Worker events")

[commit-bot: I haz the power, 2017-03-24 14:11:38]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-24 14:56:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-24 14:56:47]

Try jobs failed on following builders:
  win_clang on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/...)

[Peter Beverloo, 2017-03-24 15:59:41]

The CQ bit was checked by peter@chromium.org

[Peter Beverloo, 2017-03-24 15:59:42]

The patchset sent to the CQ was uploaded after l-g-t-m from
haraken@chromium.org, tsepez@chromium.org, isherman@chromium.org,
kinuko@chromium.org
Link to the patchset: https://codereview.chromium.org/2767093004/#ps100001
(title: "forward declare the data view")

[commit-bot: I haz the power, 2017-03-24 16:00:15]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-24 17:38:25]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1490371181793060,
"parent_rev": "ea8c4aea7e40b862accb2ae6e588e328d5a8523d", "commit_rev":
"4b613c4cd7c83a70d4f176bcb6394b2a800bbd4d"}

[commit-bot: I haz the power, 2017-03-24 17:40:25]

Description was changed from

==========
Implement the BackgroundFetch{Fail,ed} Service Worker events

This CL implements the two final events part of the Background Fetch
API: backgroundfetchfail and backgroundfetched. They'll be dispatched
from the BackgroundFetchEventDispatcher, through the
ServiceWorkerEventDispatcher, to the renderer, where they'll run.

The BackgroundFetchSettledFetch structure has been defined in the
SWEventDispatcher's mojom file, but will move to its more appropriate
location in Blink when the ServiceWorkerFetchRequest/Response types
have been migrated to Mojo proper. This is in-progress.

BUG=692534, 692581
==========

to

==========
Implement the BackgroundFetch{Fail,ed} Service Worker events

This CL implements the two final events part of the Background Fetch
API: backgroundfetchfail and backgroundfetched. They'll be dispatched
from the BackgroundFetchEventDispatcher, through the
ServiceWorkerEventDispatcher, to the renderer, where they'll run.

The BackgroundFetchSettledFetch structure has been defined in the
SWEventDispatcher's mojom file, but will move to its more appropriate
location in Blink when the ServiceWorkerFetchRequest/Response types
have been migrated to Mojo proper. This is in-progress.

BUG=692534, 692581

Review-Url: https://codereview.chromium.org/2767093004
Cr-Commit-Position: refs/heads/master@{#459469}
Committed:
https://chromium.googlesource.com/chromium/src/+/4b613c4cd7c83a70d4f176bcb639...
==========

[commit-bot: I haz the power, 2017-03-24 17:40:27]

Committed patchset #6 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/4b613c4cd7c83a70d4f176bcb639...