Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1614)

Unified Diff: content/browser/service_worker/service_worker_metrics.cc

Issue 2767093004: Implement the BackgroundFetch{Fail,ed} Service Worker events (Closed)
Patch Set: forward declare the data view Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/service_worker/service_worker_metrics.cc
diff --git a/content/browser/service_worker/service_worker_metrics.cc b/content/browser/service_worker/service_worker_metrics.cc
index c64657e65c755151a2e21de6866abbb3c830d161..d3beb3b199eb0b50e4b6db1d6b7e90faf1b5d70b 100644
--- a/content/browser/service_worker/service_worker_metrics.cc
+++ b/content/browser/service_worker/service_worker_metrics.cc
@@ -86,6 +86,10 @@ std::string EventTypeToSuffix(ServiceWorkerMetrics::EventType event_type) {
return "_BACKGROUND_FETCH_ABORT";
case ServiceWorkerMetrics::EventType::BACKGROUND_FETCH_CLICK:
return "_BACKGROUND_FETCH_CLICK";
+ case ServiceWorkerMetrics::EventType::BACKGROUND_FETCH_FAIL:
+ return "_BACKGROUND_FETCH_FAIL";
+ case ServiceWorkerMetrics::EventType::BACKGROUND_FETCHED:
+ return "_BACKGROUND_FETCHED";
case ServiceWorkerMetrics::EventType::NUM_TYPES:
NOTREACHED() << static_cast<int>(event_type);
}
@@ -365,6 +369,10 @@ const char* ServiceWorkerMetrics::EventTypeToString(EventType event_type) {
return "Background Fetch Abort";
case EventType::BACKGROUND_FETCH_CLICK:
return "Background Fetch Click";
+ case EventType::BACKGROUND_FETCH_FAIL:
+ return "Background Fetch Fail";
+ case EventType::BACKGROUND_FETCHED:
+ return "Background Fetched";
case EventType::NUM_TYPES:
break;
}
@@ -703,6 +711,14 @@ void ServiceWorkerMetrics::RecordEventDuration(EventType event,
UMA_HISTOGRAM_MEDIUM_TIMES("ServiceWorker.BackgroundFetchClickEvent.Time",
time);
break;
+ case EventType::BACKGROUND_FETCH_FAIL:
+ UMA_HISTOGRAM_MEDIUM_TIMES("ServiceWorker.BackgroundFetchFailEvent.Time",
+ time);
+ break;
+ case EventType::BACKGROUND_FETCHED:
+ UMA_HISTOGRAM_MEDIUM_TIMES("ServiceWorker.BackgroundFetchedEvent.Time",
+ time);
+ break;
// Those navigation hints should not be sent as request events.
case EventType::NAVIGATION_HINT_LINK_MOUSE_DOWN:
case EventType::NAVIGATION_HINT_LINK_TAP_UNCONFIRMED:

Powered by Google App Engine
This is Rietveld 408576698