Add trivial animation page to trivial_sites perf benchmark.

Add trivial animation page to trivial_sites perf benchmark.

Adds a page with a simple 60fps animation to the trivial_sites benchmark.

R=erikchen@chromium.org, sullivan@chromium.org
BUG=697555
Review-Url: https://codereview.chromium.org/2766763004
Cr-Commit-Position: refs/heads/master@{#459256}
Committed: https://chromium.googlesource.com/chromium/src/+/54e1c311ed2f6b1b3cf675c5aad93bfd5660c05e

[shrike, 2017-03-21 22:53:35]

PTAL

[sullivan, 2017-03-22 13:40:49]

lgtm

[erikchen, 2017-03-22 16:56:36]

On 2017/03/22 13:40:49, sullivan wrote:
> lgtm

You'll need to rebase on top of: https://codereview.chromium.org/2764663002/

Any reason why we can't reuse the existing gif? See bunny.gif.

Also, we don't add binaries directly to the repo, instead, we add them to cloud
storage. sullivan probably knows the best way to do this.

[sullivan, 2017-03-22 19:49:13]

On 2017/03/22 16:56:36, erikchen wrote:
> On 2017/03/22 13:40:49, sullivan wrote:
> > lgtm
> 
> You'll need to rebase on top of: https://codereview.chromium.org/2764663002/
> 
> Any reason why we can't reuse the existing gif? See bunny.gif.
> 
> Also, we don't add binaries directly to the repo, instead, we add them to
cloud
> storage. sullivan probably knows the best way to do this.

Oh, I thought you added as a file on purpose. There are tradeoffs:

Adding as a file is simpler, and the most reduced test case.
Adding as a WPR recording in cloud storage goes through more of the normal page
load stack, if you want to test that, and allows us to manage copyrighted
content.

If you do NOT own the copyright for the gif, you must add as WPR recording in
cloud storage.

Here are the WPR instructions:
https://www.chromium.org/developers/telemetry/record_a_page_set

[shrike, 2017-03-22 21:04:17]

On 2017/03/22 19:49:13, sullivan wrote:
> On 2017/03/22 16:56:36, erikchen wrote:
> > On 2017/03/22 13:40:49, sullivan wrote:
> > > lgtm
> > 
> > You'll need to rebase on top of: https://codereview.chromium.org/2764663002/
> > 
> > Any reason why we can't reuse the existing gif? See bunny.gif.
> > 
> > Also, we don't add binaries directly to the repo, instead, we add them to
> cloud
> > storage. sullivan probably knows the best way to do this.
> 
> Oh, I thought you added as a file on purpose. There are tradeoffs:
> 
> Adding as a file is simpler, and the most reduced test case.
> Adding as a WPR recording in cloud storage goes through more of the normal
page
> load stack, if you want to test that, and allows us to manage copyrighted
> content.
> 
> If you do NOT own the copyright for the gif, you must add as WPR recording in
> cloud storage.
> 
> Here are the WPR instructions:
> https://www.chromium.org/developers/telemetry/record_a_page_set

The image I added is not copyrighted, so there's no issue there.

I think it would be better to use a static image than the animated bunny.gif. I
don't know how many CPU cycles are needed to animate the gif, but if it's
comparable to the cycles needed to animate the image across the screen the
additional gif cycles will make it harder to catch regressions in the
animate-across-the-screen codepaths.

My image is 1K in size - can it live in the repo or does it need to be uploaded
to cloud storage?

[sullivan, 2017-03-22 21:15:06]

On 2017/03/22 21:04:17, shrike wrote:
> On 2017/03/22 19:49:13, sullivan wrote:
> > On 2017/03/22 16:56:36, erikchen wrote:
> > > On 2017/03/22 13:40:49, sullivan wrote:
> > > > lgtm
> > > 
> > > You'll need to rebase on top of:
https://codereview.chromium.org/2764663002/
> > > 
> > > Any reason why we can't reuse the existing gif? See bunny.gif.
> > > 
> > > Also, we don't add binaries directly to the repo, instead, we add them to
> > cloud
> > > storage. sullivan probably knows the best way to do this.
> > 
> > Oh, I thought you added as a file on purpose. There are tradeoffs:
> > 
> > Adding as a file is simpler, and the most reduced test case.
> > Adding as a WPR recording in cloud storage goes through more of the normal
> page
> > load stack, if you want to test that, and allows us to manage copyrighted
> > content.
> > 
> > If you do NOT own the copyright for the gif, you must add as WPR recording
in
> > cloud storage.
> > 
> > Here are the WPR instructions:
> > https://www.chromium.org/developers/telemetry/record_a_page_set
> 
> The image I added is not copyrighted, so there's no issue there.
> 
> I think it would be better to use a static image than the animated bunny.gif.
I
> don't know how many CPU cycles are needed to animate the gif, but if it's
> comparable to the cycles needed to animate the image across the screen the
> additional gif cycles will make it harder to catch regressions in the
> animate-across-the-screen codepaths.
> 
> My image is 1K in size - can it live in the repo or does it need to be
uploaded
> to cloud storage?

1K is okay to check into source.

[erikchen, 2017-03-22 21:30:35]

lgtm

[gif made me think animated]

[shrike, 2017-03-22 23:10:50]

The CQ bit was checked by shrike@chromium.org

[shrike, 2017-03-22 23:10:50]

The patchset sent to the CQ was uploaded after l-g-t-m from
sullivan@chromium.org, erikchen@chromium.org
Link to the patchset: https://codereview.chromium.org/2766763004/#ps20001
(title: "Use larger-size, smaller image.")

[commit-bot: I haz the power, 2017-03-22 23:11:49]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-22 23:16:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-22 23:16:32]

Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[shrike, 2017-03-22 23:22:54]

On 2017/03/22 23:16:32, commit-bot: I haz the power wrote:
> Try jobs failed on following builders:
>   android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
>
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
>   ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
>   mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
>   mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

(Forgot about erikchen@'s comment that I needed to rebase.}

[shrike, 2017-03-22 23:35:26]

The CQ bit was checked by shrike@chromium.org

[shrike, 2017-03-22 23:35:26]

The patchset sent to the CQ was uploaded after l-g-t-m from
sullivan@chromium.org, erikchen@chromium.org
Link to the patchset: https://codereview.chromium.org/2766763004/#ps40001
(title: "Rebase.")

[commit-bot: I haz the power, 2017-03-22 23:36:29]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-22 23:39:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-22 23:39:29]

Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[shrike, 2017-03-23 00:25:13]

It looks like the Chromium tools are not allowing the image to be added to the
source tree. Is it kosher to encode the image as a data URI within the HTML?

[sullivan, 2017-03-23 00:31:25]

On 2017/03/23 00:25:13, shrike wrote:
> It looks like the Chromium tools are not allowing the image to be added to the
> source tree. Is it kosher to encode the image as a data URI within the HTML?

That is okay as long as you don't think it will have an impact on the
performance metrics the test outputs.

[shrike, 2017-03-23 21:13:36]

On 2017/03/23 00:31:25, sullivan wrote:
> On 2017/03/23 00:25:13, shrike wrote:
> > It looks like the Chromium tools are not allowing the image to be added to
the
> > source tree. Is it kosher to encode the image as a data URI within the HTML?
> 
> That is okay as long as you don't think it will have an impact on the
> performance metrics the test outputs.

It should not affect the test itself.

[sullivan, 2017-03-23 21:16:01]

lgtm

[shrike, 2017-03-23 21:21:43]

The CQ bit was checked by shrike@chromium.org

[shrike, 2017-03-23 21:21:43]

The patchset sent to the CQ was uploaded after l-g-t-m from
erikchen@chromium.org, sullivan@chromium.org
Link to the patchset: https://codereview.chromium.org/2766763004/#ps80001
(title: "Add comments.")

[commit-bot: I haz the power, 2017-03-23 21:22:34]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-23 22:26:56]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1490304103010530,
"parent_rev": "d6b104cb86ef80a415014191e2f10b6e0dbd501b", "commit_rev":
"54e1c311ed2f6b1b3cf675c5aad93bfd5660c05e"}

[commit-bot: I haz the power, 2017-03-23 22:27:38]

Description was changed from

==========
Add trivial animation page to trivial_sites perf benchmark.

Adds a page with a simple 60fps animation to the trivial_sites benchmark.

R=erikchen@chromium.org, sullivan@chromium.org
BUG=697555
==========

to

==========
Add trivial animation page to trivial_sites perf benchmark.

Adds a page with a simple 60fps animation to the trivial_sites benchmark.

R=erikchen@chromium.org, sullivan@chromium.org
BUG=697555

Review-Url: https://codereview.chromium.org/2766763004
Cr-Commit-Position: refs/heads/master@{#459256}
Committed:
https://chromium.googlesource.com/chromium/src/+/54e1c311ed2f6b1b3cf675c5aad9...
==========

[commit-bot: I haz the power, 2017-03-23 22:27:39]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/54e1c311ed2f6b1b3cf675c5aad9...