Fix desktop.memory measurement to emit memory-infra dumps.

Fix desktop.memory measurement to emit memory-infra dumps.

The user stories need to run action_runner.MeasureMemory.

BUG=701184
Review-Url: https://codereview.chromium.org/2764663002
Cr-Commit-Position: refs/heads/master@{#458498}
Committed: https://chromium.googlesource.com/chromium/src/+/ad84c7704a0def426d12b8501371ea0dac37134a

[erikchen, 2017-03-20 22:49:31]

Description was changed from

==========
Fix desktop.memory measurement to emit memory-infra dumps.

The user stories need to be modified to run action_runner.MeasureMemory.

BUG=701184
==========

to

==========
Fix desktop.memory measurement to emit memory-infra dumps.

The user stories need to run action_runner.MeasureMemory.

BUG=701184
==========

[erikchen, 2017-03-20 22:49:59]

erikchen@chromium.org changed reviewers:
+ nednguyen@google.com

[erikchen, 2017-03-20 22:50:00]

nednguyen: Please review.

[nednguyen, 2017-03-21 15:29:24]

Description was changed from

==========
Fix desktop.memory measurement to emit memory-infra dumps.

The user stories need to run action_runner.MeasureMemory.

BUG=701184
==========

to

==========
Fix desktop.memory measurement to emit memory-infra dumps.

The user stories need to run action_runner.MeasureMemory.

BUG=701184
==========

[nednguyen, 2017-03-21 15:30:45]

On 2017/03/20 22:50:00, erikchen wrote:
> nednguyen: Please review.

lgtm

+Primiano/Hector: if we can remove the explicit dump, folks won't need to go
through CL to do this :)

[Primiano Tucci (use gerrit), 2017-03-21 15:33:05]

primiano@chromium.org changed reviewers:
+ perezju@chromium.org, primiano@chromium.org

[Primiano Tucci (use gerrit), 2017-03-21 15:33:06]

I am not too familiar with the telemetry side of things. +perezju

My only worry is that this seems to break gpu tracking on android. Probably I am
misreading the code?

https://codereview.chromium.org/2764663002/diff/1/tools/perf/benchmarks/memor...
File tools/perf/benchmarks/memory.py (left):

https://codereview.chromium.org/2764663002/diff/1/tools/perf/benchmarks/memor...
tools/perf/benchmarks/memory.py:37:
tbm_options.config.enable_android_graphics_memtrack = True
isn't this going to lose graphics memtrack coverage on android? I am missing
something here
I

[nednguyen, 2017-03-21 15:35:18]

https://codereview.chromium.org/2764663002/diff/1/tools/perf/benchmarks/memor...
File tools/perf/benchmarks/memory.py (left):

https://codereview.chromium.org/2764663002/diff/1/tools/perf/benchmarks/memor...
tools/perf/benchmarks/memory.py:37:
tbm_options.config.enable_android_graphics_memtrack = True
On 2017/03/21 15:33:06, Primiano Tucci wrote:
> isn't this going to lose graphics memtrack coverage on android? I am missing
> something here
> I

Yeah, this should be removed for desktop memory benchmark only

[perezju, 2017-03-21 15:48:34]

https://codereview.chromium.org/2764663002/diff/1/tools/perf/benchmarks/memor...
File tools/perf/benchmarks/memory.py (left):

https://codereview.chromium.org/2764663002/diff/1/tools/perf/benchmarks/memor...
tools/perf/benchmarks/memory.py:37:
tbm_options.config.enable_android_graphics_memtrack = True
On 2017/03/21 15:35:18, nednguyen wrote:
> On 2017/03/21 15:33:06, Primiano Tucci wrote:
> > isn't this going to lose graphics memtrack coverage on android? I am missing
> > something here
> > I
> 
> Yeah, this should be removed for desktop memory benchmark only

This should not be removed at all. It is needed for android, and ignored
elsewhere:
https://github.com/catapult-project/catapult/blob/master/telemetry/telemetry/...

Was this causing any sort of issue?

[erikchen, 2017-03-21 17:11:35]

https://codereview.chromium.org/2764663002/diff/1/tools/perf/benchmarks/memor...
File tools/perf/benchmarks/memory.py (left):

https://codereview.chromium.org/2764663002/diff/1/tools/perf/benchmarks/memor...
tools/perf/benchmarks/memory.py:37:
tbm_options.config.enable_android_graphics_memtrack = True
On 2017/03/21 15:48:34, perezju wrote:
> On 2017/03/21 15:35:18, nednguyen wrote:
> > On 2017/03/21 15:33:06, Primiano Tucci wrote:
> > > isn't this going to lose graphics memtrack coverage on android? I am
missing
> > > something here
> > > I
> > 
> > Yeah, this should be removed for desktop memory benchmark only
> 
> This should not be removed at all. It is needed for android, and ignored
> elsewhere:
>
https://github.com/catapult-project/catapult/blob/master/telemetry/telemetry/...
> 
> Was this causing any sort of issue?

whoops, I wanted to only remove this for desktop. Let me just add it back, since
it doesn't negatively affect desktop

[erikchen, 2017-03-21 17:14:42]

The CQ bit was checked by erikchen@chromium.org

[erikchen, 2017-03-21 17:14:43]

The patchset sent to the CQ was uploaded after l-g-t-m from nednguyen@google.com
Link to the patchset: https://codereview.chromium.org/2764663002/#ps20001
(title: "Add back gpu config.")

[commit-bot: I haz the power, 2017-03-21 17:15:38]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-21 19:01:49]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1490116482918210,
"parent_rev": "40e95910df7d53d209041164ebb91351890e9117", "commit_rev":
"ad84c7704a0def426d12b8501371ea0dac37134a"}

[commit-bot: I haz the power, 2017-03-21 19:06:48]

Description was changed from

==========
Fix desktop.memory measurement to emit memory-infra dumps.

The user stories need to run action_runner.MeasureMemory.

BUG=701184
==========

to

==========
Fix desktop.memory measurement to emit memory-infra dumps.

The user stories need to run action_runner.MeasureMemory.

BUG=701184

Review-Url: https://codereview.chromium.org/2764663002
Cr-Commit-Position: refs/heads/master@{#458498}
Committed:
https://chromium.googlesource.com/chromium/src/+/ad84c7704a0def426d12b8501371...
==========

[commit-bot: I haz the power, 2017-03-21 19:06:49]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/ad84c7704a0def426d12b8501371...