Rename CommandDispatcher method to start dispatching.

Rename CommandDispatcher method to start dispatching.

BUG=none
R=rohitrao@chromium.org,marq@chromium.org

Review-Url: https://codereview.chromium.org/2766663002
Cr-Commit-Position: refs/heads/master@{#458424}
Committed: https://chromium.googlesource.com/chromium/src/+/588b7bac5c4289654f11b6834e53c9de4177dd06

[lpromero, 2017-03-21 12:02:11]

The CQ bit was checked by lpromero@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-21 12:02:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[rohitrao (ping after 24h), 2017-03-21 12:05:08]

lgtm

https://codereview.chromium.org/2766663002/diff/1/ios/clean/chrome/browser/ui...
File ios/clean/chrome/browser/ui/commands/command_dispatcher.h (right):

https://codereview.chromium.org/2766663002/diff/1/ios/clean/chrome/browser/ui...
ios/clean/chrome/browser/ui/commands/command_dispatcher.h:20: -
(void)stopDispatchingForTarget:(id)target;
Should this also change to stopDispatchingToTarget?  Do we care about "to" vs
"for"?

[commit-bot: I haz the power, 2017-03-21 12:11:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-21 12:11:52]

Dry run: This issue passed the CQ dry run.

[marq (ping after 24h), 2017-03-21 12:15:10]

LGTM with naming change.

https://codereview.chromium.org/2766663002/diff/1/ios/clean/chrome/browser/ui...
File ios/clean/chrome/browser/ui/commands/command_dispatcher.h (right):

https://codereview.chromium.org/2766663002/diff/1/ios/clean/chrome/browser/ui...
ios/clean/chrome/browser/ui/commands/command_dispatcher.h:20: -
(void)stopDispatchingForTarget:(id)target;
On 2017/03/21 12:05:08, rohitrao wrote:
> Should this also change to stopDispatchingToTarget?  Do we care about "to" vs
> "for"?

Yes, we do! Please change this to match.

[lpromero, 2017-03-21 15:28:32]

The CQ bit was checked by lpromero@chromium.org to run a CQ dry run

[lpromero, 2017-03-21 15:28:54]

Thanks!

https://codereview.chromium.org/2766663002/diff/1/ios/clean/chrome/browser/ui...
File ios/clean/chrome/browser/ui/commands/command_dispatcher.h (right):

https://codereview.chromium.org/2766663002/diff/1/ios/clean/chrome/browser/ui...
ios/clean/chrome/browser/ui/commands/command_dispatcher.h:20: -
(void)stopDispatchingForTarget:(id)target;
On 2017/03/21 12:15:10, marq wrote:
> On 2017/03/21 12:05:08, rohitrao wrote:
> > Should this also change to stopDispatchingToTarget?  Do we care about "to"
vs
> > "for"?
> 
> Yes, we do! Please change this to match.

Done.

[commit-bot: I haz the power, 2017-03-21 15:28:55]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[lpromero, 2017-03-21 15:28:59]

The CQ bit was checked by lpromero@chromium.org

[lpromero, 2017-03-21 15:28:59]

The patchset sent to the CQ was uploaded after l-g-t-m from marq@chromium.org,
rohitrao@chromium.org
Link to the patchset: https://codereview.chromium.org/2766663002/#ps20001
(title: "s/For/To")

[commit-bot: I haz the power, 2017-03-21 15:29:10]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-21 15:40:47]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1490110139100120,
"parent_rev": "763a6232141799360238b6f53b728525c171d7bf", "commit_rev":
"588b7bac5c4289654f11b6834e53c9de4177dd06"}

[commit-bot: I haz the power, 2017-03-21 15:41:27]

Description was changed from

==========
Rename CommandDispatcher method to start dispatching.

BUG=none
R=rohitrao@chromium.org,marq@chromium.org
==========

to

==========
Rename CommandDispatcher method to start dispatching.

BUG=none
R=rohitrao@chromium.org,marq@chromium.org

Review-Url: https://codereview.chromium.org/2766663002
Cr-Commit-Position: refs/heads/master@{#458424}
Committed:
https://chromium.googlesource.com/chromium/src/+/588b7bac5c4289654f11b6834e53...
==========

[commit-bot: I haz the power, 2017-03-21 15:41:28]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/588b7bac5c4289654f11b6834e53...