ios/clean/chrome/browser/ui/commands/command_dispatcher.h - Issue 2766663002: Rename CommandDispatcher method to start dispatching.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ios/clean/chrome/browser/ui/commands/command_dispatcher.h

Issue 2766663002: Rename CommandDispatcher method to start dispatching. (Closed)

Patch Set: Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | ios/clean/chrome/browser/ui/commands/command_dispatcher.mm » ('j') | no next file with comments »

OLD	NEW
1 // Copyright 2017 The Chromium Authors. All rights reserved.	1 // Copyright 2017 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef IOS_CLEAN_CHROME_BROWSER_UI_COMMANDS_COMMAND_DISPATCHER_H_	5 #ifndef IOS_CLEAN_CHROME_BROWSER_UI_COMMANDS_COMMAND_DISPATCHER_H_

6 #define IOS_CLEAN_CHROME_BROWSER_UI_COMMANDS_COMMAND_DISPATCHER_H_	6 #define IOS_CLEAN_CHROME_BROWSER_UI_COMMANDS_COMMAND_DISPATCHER_H_

7	7

8 #import <Foundation/Foundation.h>	8 #import <Foundation/Foundation.h>

9	9

10 // CommandDispatcher allows coordinators to register as command handlers for	10 // CommandDispatcher allows coordinators to register as command handlers for

11 // specific selectors. Other objects can call these methods on the dispatcher,	11 // specific selectors. Other objects can call these methods on the dispatcher,

12 // which in turn will forward the call to the registered handler.	12 // which in turn will forward the call to the registered handler.

13 @interface CommandDispatcher : NSObject	13 @interface CommandDispatcher : NSObject

14	14

15 // Registers the given \|target\| to receive forwarded messages for the given	15 // Registers the given \|target\| to receive forwarded messages for the given

16 // \|selector\|.	16 // \|selector\|.

17 - (void)registerTarget:(id)target forSelector:(SEL)selector;	17 - (void)startDispatchingToTarget:(id)target forSelector:(SEL)selector;

18	18

19 // Removes all forwarding registrations for the given \|target\|.	19 // Removes all forwarding registrations for the given \|target\|.

20 - (void)stopDispatchingForTarget:(id)target;	20 - (void)stopDispatchingForTarget:(id)target;
	rohitrao (ping after 24h) 2017/03/21 12:05:08 Should this also change to stopDispatchingToTarget Should this also change to stopDispatchingToTarget? Do we care about "to" vs "for"? marq (ping after 24h) 2017/03/21 12:15:10 Yes, we do! Please change this to match. Show quoted text On 2017/03/21 12:05:08, rohitrao wrote: > Should this also change to stopDispatchingToTarget? Do we care about "to" vs > "for"? Yes, we do! Please change this to match. lpromero 2017/03/21 15:28:54 Done. Show quoted text On 2017/03/21 12:15:10, marq wrote: > On 2017/03/21 12:05:08, rohitrao wrote: > > Should this also change to stopDispatchingToTarget? Do we care about "to" vs > > "for"? > > Yes, we do! Please change this to match. Done.
21	21

22 @end	22 @end

23	23

24 #endif // IOS_CLEAN_CHROME_BROWSER_UI_COMMANDS_COMMAND_DISPATCHER_H_	24 #endif // IOS_CLEAN_CHROME_BROWSER_UI_COMMANDS_COMMAND_DISPATCHER_H_

OLD	NEW