Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Issue 2766593002: [csa] Migrate String.prototype.concat to TurboFan builtin. (Closed)

Created:
3 years, 9 months ago by Benedikt Meurer
Modified:
3 years, 9 months ago
Reviewers:
Yang
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

[csa] Migrate String.prototype.concat to TurboFan builtin. R=yangguo@chromium.org BUG=v8:5049 Review-Url: https://codereview.chromium.org/2766593002 Cr-Commit-Position: refs/heads/master@{#43961} Committed: https://chromium.googlesource.com/v8/v8/+/0a7d31380029c28714f7f45bb4158cbb1bef9314

Patch Set 1 #

Patch Set 2 : Magical list is magic... #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -16 lines) Patch
M src/bootstrapper.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M src/builtins/builtins.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/builtins/builtins-string-gen.cc View 1 chunk +24 lines, -0 lines 0 comments Download
M src/code-factory.h View 1 chunk +3 lines, -2 lines 0 comments Download
M src/debug/debug-evaluate.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/js/string.js View 2 chunks +0 lines, -14 lines 0 comments Download

Messages

Total messages: 14 (10 generated)
Benedikt Meurer
3 years, 9 months ago (2017-03-21 05:47:45 UTC) #1
Yang
On 2017/03/21 05:47:45, Benedikt Meurer wrote: lgtm.
3 years, 9 months ago (2017-03-21 06:14:47 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2766593002/20001
3 years, 9 months ago (2017-03-21 06:20:55 UTC) #11
commit-bot: I haz the power
3 years, 9 months ago (2017-03-21 06:36:17 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/0a7d31380029c28714f7f45bb4158cbb1be...

Powered by Google App Engine
This is Rietveld 408576698