Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1323)

Unified Diff: src/js/string.js

Issue 2766593002: [csa] Migrate String.prototype.concat to TurboFan builtin. (Closed)
Patch Set: Magical list is magic... Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/debug/debug-evaluate.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/js/string.js
diff --git a/src/js/string.js b/src/js/string.js
index df305e35ca080c94cb7cfb6034a44b87b8920934..1aa1700a1d6120baf05006565ce73a319a365b93 100644
--- a/src/js/string.js
+++ b/src/js/string.js
@@ -15,19 +15,6 @@ var searchSymbol = utils.ImportNow("search_symbol");
//-------------------------------------------------------------------
-// ECMA-262, section 15.5.4.6
-function StringConcat(other /* and more */) { // length == 1
- "use strict";
- CHECK_OBJECT_COERCIBLE(this, "String.prototype.concat");
- var s = TO_STRING(this);
- var len = arguments.length;
- for (var i = 0; i < len; ++i) {
- s = s + TO_STRING(arguments[i]);
- }
- return s;
-}
-
-
// ES6 21.1.3.11.
function StringMatchJS(pattern) {
CHECK_OBJECT_COERCIBLE(this, "String.prototype.match");
@@ -288,7 +275,6 @@ utils.InstallFunctions(GlobalString, DONT_ENUM, [
// Set up the non-enumerable functions on the String prototype object.
utils.InstallFunctions(GlobalString.prototype, DONT_ENUM, [
"codePointAt", StringCodePointAt,
- "concat", StringConcat,
"match", StringMatchJS,
"repeat", StringRepeat,
"search", StringSearch,
« no previous file with comments | « src/debug/debug-evaluate.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698