Image Capture: wire getSettings() from MediaStreamTrack

Image Capture: wire getSettings() from MediaStreamTrack

This CL wires the fourth and last Constrainable Pattern
method, MediaStreamTrack.getSettings(), appending
Image-Capture specific Settings to what is returned
now.

ImageCapture::getMediaTrackSettings simply extends the
parameter |settings| with whatever the current |m_capabilities|
holds.  Perhaps confusingly, ImageCapture::m_capabilities 
includes _both_ working ranges and current values so, in a way, 
it encompasses the capabilities and the settings; this is
due to the previous API (and mojo) design, and will be 
untangled in subsequent CLs.

Also, this CL forces an update of |m_capabilities| when
configuring or reading the device. 

A few LayoutTests are added, including one where the
applied constraints are retrieved with getSettings and
compared (the mojo mock is extended to latch the former
blindly).

BUG=700607
Review-Url: https://codereview.chromium.org/2766473002
Cr-Commit-Position: refs/heads/master@{#458495}
Committed: https://chromium.googlesource.com/chromium/src/+/863711a1f0b27b5aa30ed18af6932eae19ccf5fc

[mcasas, 2017-03-21 00:44:54]

Description was changed from

==========
Image Capture: wire getSettings() from MediaStreamTrack


BUG=700607
==========

to

==========
Image Capture: wire getSettings() from MediaStreamTrack

This CL wires the fourth and last Constrainable Pattern
method, MediaStreamTrack.getSettings(), appending
Image-Capture specific Settings to what is returned
now.

ImageCapture::getMediaTrackSettings simply extends the
parameter |settings| with whatever the current |m_capabilities|
holds.  Perhaps confusingly, ImageCapture::m_capabilities 
includes _both_ working ranges and current values so, in a way, 
it encompasses the capabilities and the settings; this is
due to the previous API (and mojo) design, and will be 
untangled in subsequent CLs.

Also, ImageCapture forces an update of |m_capabilities| when
configuring or reading the device. 

A few LayoutTests are added, including one where the
applied constraints are retrieved with getSettings and
compared (the mojo mock is extended to latch the former
blindly).

BUG=700607
==========

[mcasas, 2017-03-21 00:45:05]

Patchset #1 (id:1) has been deleted

[mcasas, 2017-03-21 00:53:30]

Patchset #1 (id:20001) has been deleted

[mcasas, 2017-03-21 01:06:22]

mcasas@chromium.org changed reviewers:
+ guidou@chromium.org, reillyg@chromium.org

[mcasas, 2017-03-21 01:06:23]

reillyg@ ptal

guidou@ ptal mediastream/

[mcasas, 2017-03-21 01:07:23]

Description was changed from

==========
Image Capture: wire getSettings() from MediaStreamTrack

This CL wires the fourth and last Constrainable Pattern
method, MediaStreamTrack.getSettings(), appending
Image-Capture specific Settings to what is returned
now.

ImageCapture::getMediaTrackSettings simply extends the
parameter |settings| with whatever the current |m_capabilities|
holds.  Perhaps confusingly, ImageCapture::m_capabilities 
includes _both_ working ranges and current values so, in a way, 
it encompasses the capabilities and the settings; this is
due to the previous API (and mojo) design, and will be 
untangled in subsequent CLs.

Also, ImageCapture forces an update of |m_capabilities| when
configuring or reading the device. 

A few LayoutTests are added, including one where the
applied constraints are retrieved with getSettings and
compared (the mojo mock is extended to latch the former
blindly).

BUG=700607
==========

to

==========
Image Capture: wire getSettings() from MediaStreamTrack

This CL wires the fourth and last Constrainable Pattern
method, MediaStreamTrack.getSettings(), appending
Image-Capture specific Settings to what is returned
now.

ImageCapture::getMediaTrackSettings simply extends the
parameter |settings| with whatever the current |m_capabilities|
holds.  Perhaps confusingly, ImageCapture::m_capabilities 
includes _both_ working ranges and current values so, in a way, 
it encompasses the capabilities and the settings; this is
due to the previous API (and mojo) design, and will be 
untangled in subsequent CLs.

Also, this CL forces an update of |m_capabilities| when
configuring or reading the device. 

A few LayoutTests are added, including one where the
applied constraints are retrieved with getSettings and
compared (the mojo mock is extended to latch the former
blindly).

BUG=700607
==========

[Reilly Grant (use Gerrit), 2017-03-21 01:25:17]

https://codereview.chromium.org/2766473002/diff/40001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/imagecapture/MediaStreamTrack-applyConstraints-getSettings.html
(right):

https://codereview.chromium.org/2766473002/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/imagecapture/MediaStreamTrack-applyConstraints-getSettings.html:20:

nit: extra whitespace

https://codereview.chromium.org/2766473002/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/imagecapture/MediaStreamTrack-applyConstraints-getSettings.html:49:
.catch(error => {
To catch just errors from mockImageCapture ready this function should be passed
as the second argument to then(), not to the catch() on the Promise it returns.

https://codereview.chromium.org/2766473002/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/imagecapture/MediaStreamTrack-applyConstraints-getSettings.html:87:
assert_unreached("Error creating MockImageCapture: " + error);
Error applying constraints?

https://codereview.chromium.org/2766473002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/imagecapture/ImageCapture.cpp (right):

https://codereview.chromium.org/2766473002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/imagecapture/ImageCapture.cpp:391: DVLOG(1) <<
__func__;
Left over logging?

https://codereview.chromium.org/2766473002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/imagecapture/ImageCapture.cpp:446: DVLOG(1) <<
__func__;
Left over debug logging?

[mcasas, 2017-03-21 02:35:37]

Patchset #2 (id:60001) has been deleted

[mcasas, 2017-03-21 02:39:58]

Patchset #3 (id:100001) has been deleted

[mcasas, 2017-03-21 02:40:03]

Patchset #2 (id:80001) has been deleted

[mcasas, 2017-03-21 02:40:11]

ptal

https://codereview.chromium.org/2766473002/diff/40001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/imagecapture/MediaStreamTrack-applyConstraints-getSettings.html
(right):

https://codereview.chromium.org/2766473002/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/imagecapture/MediaStreamTrack-applyConstraints-getSettings.html:20:

On 2017/03/21 01:25:17, Reilly Grant wrote:
> nit: extra whitespace

Done.

https://codereview.chromium.org/2766473002/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/imagecapture/MediaStreamTrack-applyConstraints-getSettings.html:49:
.catch(error => {
On 2017/03/21 01:25:17, Reilly Grant wrote:
> To catch just errors from mockImageCapture ready this function should be
passed
> as the second argument to then(), not to the catch() on the Promise it
returns.

Gotcha. I got it wrong in the other mock-based tests
around here, will adapt them in another CL very soon.
(https://codereview.chromium.org/2762883002)

https://codereview.chromium.org/2766473002/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/imagecapture/MediaStreamTrack-applyConstraints-getSettings.html:87:
assert_unreached("Error creating MockImageCapture: " + error);
On 2017/03/21 01:25:17, Reilly Grant wrote:
> Error applying constraints?

Done.

https://codereview.chromium.org/2766473002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/imagecapture/ImageCapture.cpp (right):

https://codereview.chromium.org/2766473002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/imagecapture/ImageCapture.cpp:391: DVLOG(1) <<
__func__;
On 2017/03/21 01:25:17, Reilly Grant wrote:
> Left over logging?

Done.

https://codereview.chromium.org/2766473002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/imagecapture/ImageCapture.cpp:446: DVLOG(1) <<
__func__;
On 2017/03/21 01:25:17, Reilly Grant wrote:
> Left over debug logging?

Removed all stray DVLOG()s

[Guido Urdaneta, 2017-03-21 10:28:16]

mediastream lgtm

[mcasas, 2017-03-21 17:11:28]

reillyg@ ptal

[Reilly Grant (use Gerrit), 2017-03-21 17:20:52]

lgtm

[mcasas, 2017-03-21 17:54:10]

The CQ bit was checked by mcasas@chromium.org

[commit-bot: I haz the power, 2017-03-21 17:55:00]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-21 18:56:46]

CQ is committing da patch.

Bot data: {"patchset_id": 120001, "attempt_start_ts": 1490118850676250,
"parent_rev": "90df8ca1bd1aa6218fb937249f38ed59dcaf19a5", "commit_rev":
"863711a1f0b27b5aa30ed18af6932eae19ccf5fc"}

[commit-bot: I haz the power, 2017-03-21 18:57:31]

Description was changed from

==========
Image Capture: wire getSettings() from MediaStreamTrack

This CL wires the fourth and last Constrainable Pattern
method, MediaStreamTrack.getSettings(), appending
Image-Capture specific Settings to what is returned
now.

ImageCapture::getMediaTrackSettings simply extends the
parameter |settings| with whatever the current |m_capabilities|
holds.  Perhaps confusingly, ImageCapture::m_capabilities 
includes _both_ working ranges and current values so, in a way, 
it encompasses the capabilities and the settings; this is
due to the previous API (and mojo) design, and will be 
untangled in subsequent CLs.

Also, this CL forces an update of |m_capabilities| when
configuring or reading the device. 

A few LayoutTests are added, including one where the
applied constraints are retrieved with getSettings and
compared (the mojo mock is extended to latch the former
blindly).

BUG=700607
==========

to

==========
Image Capture: wire getSettings() from MediaStreamTrack

This CL wires the fourth and last Constrainable Pattern
method, MediaStreamTrack.getSettings(), appending
Image-Capture specific Settings to what is returned
now.

ImageCapture::getMediaTrackSettings simply extends the
parameter |settings| with whatever the current |m_capabilities|
holds.  Perhaps confusingly, ImageCapture::m_capabilities 
includes _both_ working ranges and current values so, in a way, 
it encompasses the capabilities and the settings; this is
due to the previous API (and mojo) design, and will be 
untangled in subsequent CLs.

Also, this CL forces an update of |m_capabilities| when
configuring or reading the device. 

A few LayoutTests are added, including one where the
applied constraints are retrieved with getSettings and
compared (the mojo mock is extended to latch the former
blindly).

BUG=700607

Review-Url: https://codereview.chromium.org/2766473002
Cr-Commit-Position: refs/heads/master@{#458495}
Committed:
https://chromium.googlesource.com/chromium/src/+/863711a1f0b27b5aa30ed18af693...
==========

[commit-bot: I haz the power, 2017-03-21 18:57:32]

Committed patchset #2 (id:120001) as
https://chromium.googlesource.com/chromium/src/+/863711a1f0b27b5aa30ed18af693...