Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 2762883002: Image Capture layouttests: correct mockImageCaptureReady error callback (Closed)

Created:
3 years, 9 months ago by mcasas
Modified:
3 years, 9 months ago
CC:
chromium-reviews, blink-reviews, mcasas+imagecapture_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Image Capture layouttests: correct mockImageCaptureReady error callback This CL corrects the uses of mockImageCaptureReady error path: mockImageCaptureReady pings back an error function and doesn't reject a Promise; also there's some minor editing to homogenise logs. BUG=700607 Review-Url: https://codereview.chromium.org/2762883002 Cr-Commit-Position: refs/heads/master@{#458474} Committed: https://chromium.googlesource.com/chromium/src/+/c7395a29c5651500067cf1c0dbe0db2ab180f3e4

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -18 lines) Patch
M third_party/WebKit/LayoutTests/imagecapture/MediaStreamTrack-applyConstraints.html View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/imagecapture/MediaStreamTrack-getCapabilities.html View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/imagecapture/getphotocapabilities.html View 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/imagecapture/setoptions.html View 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/imagecapture/takephoto.html View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 17 (13 generated)
mcasas
reillyg@ cleanup CL, PTAL
3 years, 9 months ago (2017-03-21 17:11:15 UTC) #11
Reilly Grant (use Gerrit)
lgtm
3 years, 9 months ago (2017-03-21 17:26:05 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2762883002/20001
3 years, 9 months ago (2017-03-21 18:05:13 UTC) #14
commit-bot: I haz the power
3 years, 9 months ago (2017-03-21 18:13:26 UTC) #17
Message was sent while issue was closed.
Committed patchset #1 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/c7395a29c5651500067cf1c0dbe0...

Powered by Google App Engine
This is Rietveld 408576698