DLL Export AXPlatformNodeWin.

DLL Export AXPlatformNodeWin.

In order to use ui::AXPlatformNodeWin from content, we must dll export
these classes.

BUG=703369
Review-Url: https://codereview.chromium.org/2766463002
Cr-Commit-Position: refs/heads/master@{#459376}
Committed: https://chromium.googlesource.com/chromium/src/+/8abfeeb28cc7c6a4fb2bfeca1da3dc82d13ea24b

[dougt, 2017-03-20 23:12:39]

The CQ bit was checked by dougt@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-20 23:13:12]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dougt, 2017-03-20 23:50:25]

dougt@chromium.org changed reviewers:
+ dmazzoni@chromium.org

[commit-bot: I haz the power, 2017-03-21 00:01:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-21 00:01:27]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[dougt, 2017-03-21 16:23:16]

The CQ bit was checked by dougt@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-21 16:24:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[nektarios, 2017-03-21 16:27:35]

Better link to the very latest docs instead of to 2005.
https://msdn.microsoft.com/en-us/library/3tdb471s(v=vs.140).aspx

[nektarios, 2017-03-21 16:45:52]

I am wondering if it would be better to just AX_EXPORT a template instantiation
of the base class CComRootEx<...>.
I fear that if not we might have issues with the component build of Chromium.
I am certainly not an expert.

[dmazzoni, 2017-03-21 16:50:02]

dmazzoni@chromium.org changed reviewers:
+ ananta@chromium.org, cpu@chromium.org

[dmazzoni, 2017-03-21 16:50:02]

lgtm, but I was previously unfamiliar with this warning.

@cpu or @ananta, could either of you confirm that this
looks reasonable?

[cpu_(ooo_6.6-7.5), 2017-03-23 00:54:41]

hmm, I would typically ask rvargas@ but he is gone. There is trickiness
exporting classes that are not pod-like Maybe also ask scottmg?

[scottmg, 2017-03-23 01:16:14]

scottmg@chromium.org changed reviewers:
+ scottmg@chromium.org

[scottmg, 2017-03-23 01:16:14]

We have a macro for this, see NON_EXPORTED_BASE. Please use that instead of
disabling the warning inline.

[dougt, 2017-03-23 03:53:15]

On 2017/03/23 01:16:14, scottmg wrote:
> We have a macro for this, see NON_EXPORTED_BASE. Please use that instead of
> disabling the warning inline.

Awesome suggestion, thx!

[dougt, 2017-03-23 03:54:27]

Description was changed from

==========
DLL Export AXPlatformNodeBase and AXPlatformNodeWin.

In order to use ui::AXPlatformNodeWin and ui:AXPlatformNodeBase from content,
we must dll export these classes.

BUG=703369
==========

to

==========
DLL Export AXPlatformNodeWin.

In order to use ui::AXPlatformNodeWin from content, we must dll export
these classes.

BUG=703369
==========

[scottmg, 2017-03-23 05:00:10]

lgtm with that

https://codereview.chromium.org/2766463002/diff/40001/ui/accessibility/platfo...
File ui/accessibility/platform/ax_platform_node_win.h (right):

https://codereview.chromium.org/2766463002/diff/40001/ui/accessibility/platfo...
ui/accessibility/platform/ax_platform_node_win.h:12: #include
"base/observer_list.h"
#include "base/compiler_specific.h"

[dougt, 2017-03-23 14:22:40]

https://codereview.chromium.org/2766463002/diff/40001/ui/accessibility/platfo...
File ui/accessibility/platform/ax_platform_node_win.h (right):

https://codereview.chromium.org/2766463002/diff/40001/ui/accessibility/platfo...
ui/accessibility/platform/ax_platform_node_win.h:12: #include
"base/observer_list.h"
On 2017/03/23 05:00:10, scottmg wrote:
> #include "base/compiler_specific.h"

Done.

[dougt, 2017-03-24 06:02:44]

The CQ bit was checked by dougt@chromium.org

[dougt, 2017-03-24 06:02:44]

The patchset sent to the CQ was uploaded after l-g-t-m from
dmazzoni@chromium.org, scottmg@chromium.org
Link to the patchset: https://codereview.chromium.org/2766463002/#ps60001
(title: "Use NON_EXPORTED_BASE")

[commit-bot: I haz the power, 2017-03-24 06:03:15]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-24 06:46:53]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1490335364116370,
"parent_rev": "049f833eba3d4dedd636728c504f5edcb44d91e0", "commit_rev":
"8abfeeb28cc7c6a4fb2bfeca1da3dc82d13ea24b"}

[commit-bot: I haz the power, 2017-03-24 06:47:36]

Description was changed from

==========
DLL Export AXPlatformNodeWin.

In order to use ui::AXPlatformNodeWin from content, we must dll export
these classes.

BUG=703369
==========

to

==========
DLL Export AXPlatformNodeWin.

In order to use ui::AXPlatformNodeWin from content, we must dll export
these classes.

BUG=703369

Review-Url: https://codereview.chromium.org/2766463002
Cr-Commit-Position: refs/heads/master@{#459376}
Committed:
https://chromium.googlesource.com/chromium/src/+/8abfeeb28cc7c6a4fb2bfeca1da3...
==========

[commit-bot: I haz the power, 2017-03-24 06:47:37]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/8abfeeb28cc7c6a4fb2bfeca1da3...