Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Issue 2766683003: Make AXPlatformNodeDelegate::GetData() const (Closed)

Created:
3 years, 9 months ago by dougt
Modified:
3 years, 9 months ago
Reviewers:
dmazzoni
CC:
chromium-reviews, aboxhall+watch_chromium.org, tfarina, nektar+watch_chromium.org, yuzo+watch_chromium.org, je_julie, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Make AXPlatformNodeDelegate::GetData() const In prep of refactoring BrowserAccessibility, we are making AXPlatformNodeDelegate::GetData const so that it matches BrowserAccessibility::GetData. BUG=703369 Review-Url: https://codereview.chromium.org/2766683003 Cr-Commit-Position: refs/heads/master@{#459323} Committed: https://chromium.googlesource.com/chromium/src/+/bf9bcae65b9dc113edb7409c582238d5cbf7acaf

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -9 lines) Patch
M ui/accessibility/platform/ax_platform_node_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/accessibility/platform/test_ax_node_wrapper.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/accessibility/platform/test_ax_node_wrapper.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/accessibility/native_view_accessibility_auralinux.cc View 1 1 chunk +1 line, -3 lines 0 comments Download
M ui/views/accessibility/native_view_accessibility_base.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M ui/views/accessibility/native_view_accessibility_base.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 17 (11 generated)
dougt
PTAL. Especially ui/views/accessibility/native_view_accessibility. I am wondering if we should change the prototype to return an ...
3 years, 9 months ago (2017-03-21 20:25:12 UTC) #2
dmazzoni
On 2017/03/21 20:25:12, dougt wrote: > PTAL. Especially ui/views/accessibility/native_view_accessibility. I am > wondering if we ...
3 years, 9 months ago (2017-03-22 16:26:31 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2766683003/1
3 years, 9 months ago (2017-03-23 22:14:04 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: android_cronet on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_cronet/builds/105328) cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED, ...
3 years, 9 months ago (2017-03-23 22:17:21 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2766683003/20001
3 years, 9 months ago (2017-03-24 01:11:35 UTC) #14
commit-bot: I haz the power
3 years, 9 months ago (2017-03-24 01:19:03 UTC) #17
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/bf9bcae65b9dc113edb7409c5822...

Powered by Google App Engine
This is Rietveld 408576698