[ios] Change API to inform WebStateList of opener-opened relationship.

[ios] Change API to inform WebStateList of opener-opened relationship.

To allow defining WebStateList serialisation outside of the class,
e.g. in a free function, change the API used to inform WebStateList
of the opener-opened relationship by introducing a WebStateOpener
structure holding the opener WebState* and the opener navigation
index (last committed navigation item index).

BUG=546222
Review-Url: https://codereview.chromium.org/2766413004
Cr-Commit-Position: refs/heads/master@{#459413}
Committed: https://chromium.googlesource.com/chromium/src/+/500f522bed305fac47a8c180f5817716636eb0ba

[sdefresne, 2017-03-23 12:57:48]

The CQ bit was checked by sdefresne@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-23 12:58:08]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sdefresne, 2017-03-23 13:03:04]

The CQ bit was checked by sdefresne@chromium.org to run a CQ dry run

[sdefresne, 2017-03-23 13:03:08]

sdefresne@chromium.org changed reviewers:
+ rohitrao@chromium.org

[sdefresne, 2017-03-23 13:03:08]

Please take a look and send to CQ if LGTY.

[commit-bot: I haz the power, 2017-03-23 13:03:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sdefresne, 2017-03-23 13:03:16]

Patchset #1 (id:1) has been deleted

[commit-bot: I haz the power, 2017-03-23 14:34:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-23 14:34:09]

Dry run: This issue passed the CQ dry run.

[sdefresne, 2017-03-23 16:50:36]

The CQ bit was checked by sdefresne@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-23 16:51:10]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sdefresne, 2017-03-23 16:55:18]

sdefresne@chromium.org changed reviewers:
+ marq@chromium.org
- rohitrao@chromium.org

[sdefresne, 2017-03-23 16:55:19]

-rohitrao, +marq: can you review?

You suggested changing the API of WebStateList to allow serialisation without
having WebStateList depending on WindowSessionIOS. This is the API change
required (serialisation will come in a later CL).

[commit-bot: I haz the power, 2017-03-23 18:04:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-23 18:04:08]

Dry run: This issue passed the CQ dry run.

[marq (ping after 24h), 2017-03-24 09:35:27]

https://codereview.chromium.org/2766413004/diff/40001/ios/shared/chrome/brows...
File ios/shared/chrome/browser/tabs/web_state_opener.h (right):

https://codereview.chromium.org/2766413004/diff/40001/ios/shared/chrome/brows...
ios/shared/chrome/browser/tabs/web_state_opener.h:14: web::WebState* opener;
Comment on every field.

https://codereview.chromium.org/2766413004/diff/40001/ios/shared/chrome/brows...
ios/shared/chrome/browser/tabs/web_state_opener.h:18: // |navigation_index| is
negative, it will be initialised from |opener|.
I dislike magic behavior for some values of integers.

Can you have an explicit second constructor that just takes |opener| for this
instead? I realize that *functionally* what you have here does this, but I'd
rather it happened without the -1.

[sdefresne, 2017-03-24 10:08:10]

Please take another look.

https://codereview.chromium.org/2766413004/diff/40001/ios/shared/chrome/brows...
File ios/shared/chrome/browser/tabs/web_state_opener.h (right):

https://codereview.chromium.org/2766413004/diff/40001/ios/shared/chrome/brows...
ios/shared/chrome/browser/tabs/web_state_opener.h:14: web::WebState* opener;
On 2017/03/24 09:35:27, marq wrote:
> Comment on every field.

Done.

https://codereview.chromium.org/2766413004/diff/40001/ios/shared/chrome/brows...
ios/shared/chrome/browser/tabs/web_state_opener.h:18: // |navigation_index| is
negative, it will be initialised from |opener|.
On 2017/03/24 09:35:26, marq wrote:
> I dislike magic behavior for some values of integers.
> 
> Can you have an explicit second constructor that just takes |opener| for this
> instead? I realize that *functionally* what you have here does this, but I'd
> rather it happened without the -1.

Done.

[sdefresne, 2017-03-24 10:14:35]

Patchset #4 (id:80001) has been deleted

[sdefresne, 2017-03-24 10:18:56]

The CQ bit was checked by sdefresne@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-24 10:19:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-24 11:20:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-24 11:20:09]

Dry run: This issue passed the CQ dry run.

[marq (ping after 24h), 2017-03-24 11:45:23]

lgtm

[sdefresne, 2017-03-24 13:49:40]

The CQ bit was checked by sdefresne@chromium.org

[commit-bot: I haz the power, 2017-03-24 13:49:58]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-24 14:01:44]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1490363380223520,
"parent_rev": "a1ab5a9bd84f0a1cf5ebbd322124152bb4cd1323", "commit_rev":
"500f522bed305fac47a8c180f5817716636eb0ba"}

[commit-bot: I haz the power, 2017-03-24 14:02:34]

Description was changed from

==========
[ios] Change API to inform WebStateList of opener-opened relationship.

To allow defining WebStateList serialisation outside of the class,
e.g. in a free function, change the API used to inform WebStateList
of the opener-opened relationship by introducing a WebStateOpener
structure holding the opener WebState* and the opener navigation
index (last committed navigation item index).

BUG=546222
==========

to

==========
[ios] Change API to inform WebStateList of opener-opened relationship.

To allow defining WebStateList serialisation outside of the class,
e.g. in a free function, change the API used to inform WebStateList
of the opener-opened relationship by introducing a WebStateOpener
structure holding the opener WebState* and the opener navigation
index (last committed navigation item index).

BUG=546222

Review-Url: https://codereview.chromium.org/2766413004
Cr-Commit-Position: refs/heads/master@{#459413}
Committed:
https://chromium.googlesource.com/chromium/src/+/500f522bed305fac47a8c180f581...
==========

[commit-bot: I haz the power, 2017-03-24 14:02:36]

Committed patchset #4 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/500f522bed305fac47a8c180f581...