ios/clean/chrome/browser/ui/tab_grid/tab_grid_coordinator.mm - Issue 2766413004: [ios] Change API to inform WebStateList of opener-opened relationship.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/clean/chrome/browser/ui/tab_grid/tab_grid_coordinator.mm

Issue 2766413004: [ios] Change API to inform WebStateList of opener-opened relationship. (Closed)

Patch Set: Address comments. Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ios/clean/chrome/browser/ui/tab_grid/tab_grid_coordinator.mm

diff --git a/ios/clean/chrome/browser/ui/tab_grid/tab_grid_coordinator.mm b/ios/clean/chrome/browser/ui/tab_grid/tab_grid_coordinator.mm

index 9384f8ab80ca867e0d8a8d274e82399c75f48fdc..04802797b290aa9fbc51b0fa13ead1e7d27e60c3 100644

--- a/ios/clean/chrome/browser/ui/tab_grid/tab_grid_coordinator.mm

+++ b/ios/clean/chrome/browser/ui/tab_grid/tab_grid_coordinator.mm

@@ -53,7 +53,7 @@

web::WebState::CreateParams webStateCreateParams(browser->browser_state());

std::unique_ptr<web::WebState> webState =

web::WebState::Create(webStateCreateParams);

- self.webStateList.InsertWebState(0, webState.release(), nullptr);

+ self.webStateList.InsertWebState(0, webState.release());

}

self.webStateList.ActivateWebStateAt(0);

}

@@ -110,7 +110,7 @@

std::unique_ptr<web::WebState> webState =

web::WebState::Create(webStateCreateParams);

self.webStateList.InsertWebState(self.webStateList.count(),

- webState.release(), nullptr);

+ webState.release());

[self showTabAtIndex:self.webStateList.count() - 1];

}

« no previous file with comments | « ios/chrome/browser/tabs/tab_model.mm ('k') | ios/shared/chrome/browser/tabs/BUILD.gn » ('j') | no next file with comments »