Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 2766393003: cros: Defer lockscreen updateUserImage and loadUser calls. (Closed)

Created:
3 years, 9 months ago by jdufault
Modified:
3 years, 9 months ago
Reviewers:
achuithb
CC:
chromium-reviews, alemate+watch_chromium.org, achuith+watch_chromium.org, oshima+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

cros: Defer lockscreen updateUserImage and loadUser calls. Add DCHECKs so we can get stack traces to confirm the root cause and change fix if needed. BUG=699798 Review-Url: https://codereview.chromium.org/2766393003 Cr-Commit-Position: refs/heads/master@{#458952} Committed: https://chromium.googlesource.com/chromium/src/+/cf76073aac63d2e460740d7562ee1523e6a0c7d8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -6 lines) Patch
M chrome/browser/ui/webui/chromeos/login/base_webui_handler.h View 2 chunks +7 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc View 2 chunks +10 lines, -5 lines 0 comments Download

Messages

Total messages: 14 (10 generated)
jdufault
achuith@ PTAL. Thanks
3 years, 9 months ago (2017-03-22 22:15:46 UTC) #8
achuithb
lgtm
3 years, 9 months ago (2017-03-23 00:04:28 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2766393003/1
3 years, 9 months ago (2017-03-23 00:17:52 UTC) #11
commit-bot: I haz the power
3 years, 9 months ago (2017-03-23 00:29:27 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/cf76073aac63d2e460740d7562ee...

Powered by Google App Engine
This is Rietveld 408576698