Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6318)

Unified Diff: chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc

Issue 2766393003: cros: Defer lockscreen updateUserImage and loadUser calls. (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/webui/chromeos/login/base_webui_handler.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc
diff --git a/chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc b/chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc
index f3fda51e6f5645e947f22066e119fd23dfa510ee..d8ae0771c50e453cb9f83d191c7b4b1e5ae00494 100644
--- a/chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc
+++ b/chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc
@@ -1023,8 +1023,12 @@ void SigninScreenHandler::OnUserRemoved(const AccountId& account_id,
}
void SigninScreenHandler::OnUserImageChanged(const user_manager::User& user) {
- if (page_is_ready())
- CallJS("login.AccountPickerScreen.updateUserImage", user.GetAccountId());
+ if (page_is_ready()) {
+ // TODO(jdufault): Remove DCHECK after resolving crbug.com/699798
+ DCHECK(is_js_initialized_and_ready());
+ CallJSOrDefer("login.AccountPickerScreen.updateUserImage",
+ user.GetAccountId());
+ }
}
void SigninScreenHandler::OnPreferencesChanged() {
@@ -1294,9 +1298,10 @@ void SigninScreenHandler::HandleToggleKioskAutolaunchScreen() {
void SigninScreenHandler::LoadUsers(const base::ListValue& users_list,
bool showGuest) {
- CallJS("login.AccountPickerScreen.loadUsers",
- users_list,
- delegate_->IsShowGuest());
+ // TODO(jdufault): Remove DCHECK after resolving crbug.com/699798
+ DCHECK(is_js_initialized_and_ready());
+ CallJSOrDefer("login.AccountPickerScreen.loadUsers", users_list,
+ delegate_->IsShowGuest());
}
void SigninScreenHandler::HandleAccountPickerReady() {
« no previous file with comments | « chrome/browser/ui/webui/chromeos/login/base_webui_handler.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698