Reland of Simplify ExtensionInstallChecker into a single-use class

Reland of Simplify ExtensionInstallChecker into a single-use class (patchset #1 id:1 of https://codereview.chromium.org/2769813004/ )

Reason for revert:
The issue fixed itself without a revert.

Original issue's description:
> Revert of Simplify ExtensionInstallChecker into a single-use class (patchset #7 id:120001 of https://codereview.chromium.org/2751013002/ )
> 
> Reason for revert:
> Speculative revert for ServiceWorkerTest.ServiceWorkerSuspensionOnExtensionUnload failure on the following bot:
> https://uberchromegw.corp.google.com/i/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29/builds/58372
> 
> Original issue's description:
> > Simplify ExtensionInstallChecker into a single-use class
> > 
> > ExtensionInstallChecker does asynchronous checks, and its set of checks
> > can be started more than once. This functionality isn't being used and
> > makes the class more complicated. Remove
> > ExtensionInstallChecker::ResetResults().
> > 
> > It's also unclear why the users of this class (CrxInstaller and
> > UnpackedInstaller) are intentionally storing their Profile and Extension
> > pointers in ExtensionInstallChecker class instead of remembering them
> > locally, so update that and remove
> > ExtensionInstallChecker::set_extension().
> > 
> > Lastly, allocate the ExtensionInstallChecker dynamically since we don't
> > always use it.
> > 
> > BUG=none
> > R=rdevlin.cronin@chromium.org
> > 
> > Review-Url: https://codereview.chromium.org/2751013002
> > Cr-Commit-Position: refs/heads/master@{#458883}
> > Committed: https://chromium.googlesource.com/chromium/src/+/b24adc5bcbfde7fd67c6b23c3b0721610c77f63b
> 
> TBR=rdevlin.cronin@chromium.org,michaelpg@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=none
> 
> Review-Url: https://codereview.chromium.org/2769813004
> Cr-Commit-Position: refs/heads/master@{#458932}
> Committed: https://chromium.googlesource.com/chromium/src/+/9cc4c29fd455f27d818bcca95934a2da2332459e

TBR=rdevlin.cronin@chromium.org,michaelpg@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=none

Review-Url: https://codereview.chromium.org/2766303003
Cr-Commit-Position: refs/heads/master@{#458955}
Committed: https://chromium.googlesource.com/chromium/src/+/d741d25d04cbff8e7647d204a43dc4dfa76093ca

[dgozman, 2017-03-23 00:29:55]

The CQ bit was checked by dgozman@chromium.org

[dgozman, 2017-03-23 00:29:55]

Created Reland of Simplify ExtensionInstallChecker into a single-use class

[commit-bot: I haz the power, 2017-03-23 00:30:47]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-23 00:35:38]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1490228995095830, "parent_rev":
"649b3edd4d074b63688f31671cf36ca7cb8ff53b", "commit_rev":
"d741d25d04cbff8e7647d204a43dc4dfa76093ca"}

[commit-bot: I haz the power, 2017-03-23 00:36:56]

Description was changed from

==========
Reland of Simplify ExtensionInstallChecker into a single-use class (patchset #1
id:1 of https://codereview.chromium.org/2769813004/ )

Reason for revert:
The issue fixed itself without a revert.

Original issue's description:
> Revert of Simplify ExtensionInstallChecker into a single-use class (patchset
#7 id:120001 of https://codereview.chromium.org/2751013002/ )
> 
> Reason for revert:
> Speculative revert for
ServiceWorkerTest.ServiceWorkerSuspensionOnExtensionUnload failure on the
following bot:
>
https://uberchromegw.corp.google.com/i/chromium.win/builders/Win7%20Tests%20%...
> 
> Original issue's description:
> > Simplify ExtensionInstallChecker into a single-use class
> > 
> > ExtensionInstallChecker does asynchronous checks, and its set of checks
> > can be started more than once. This functionality isn't being used and
> > makes the class more complicated. Remove
> > ExtensionInstallChecker::ResetResults().
> > 
> > It's also unclear why the users of this class (CrxInstaller and
> > UnpackedInstaller) are intentionally storing their Profile and Extension
> > pointers in ExtensionInstallChecker class instead of remembering them
> > locally, so update that and remove
> > ExtensionInstallChecker::set_extension().
> > 
> > Lastly, allocate the ExtensionInstallChecker dynamically since we don't
> > always use it.
> > 
> > BUG=none
> > R=rdevlin.cronin@chromium.org
> > 
> > Review-Url: https://codereview.chromium.org/2751013002
> > Cr-Commit-Position: refs/heads/master@{#458883}
> > Committed:
https://chromium.googlesource.com/chromium/src/+/b24adc5bcbfde7fd67c6b23c3b07...
> 
> TBR=rdevlin.cronin@chromium.org,michaelpg@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=none
> 
> Review-Url: https://codereview.chromium.org/2769813004
> Cr-Commit-Position: refs/heads/master@{#458932}
> Committed:
https://chromium.googlesource.com/chromium/src/+/9cc4c29fd455f27d818bcca95934...

TBR=rdevlin.cronin@chromium.org,michaelpg@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=none
==========

to

==========
Reland of Simplify ExtensionInstallChecker into a single-use class (patchset #1
id:1 of https://codereview.chromium.org/2769813004/ )

Reason for revert:
The issue fixed itself without a revert.

Original issue's description:
> Revert of Simplify ExtensionInstallChecker into a single-use class (patchset
#7 id:120001 of https://codereview.chromium.org/2751013002/ )
> 
> Reason for revert:
> Speculative revert for
ServiceWorkerTest.ServiceWorkerSuspensionOnExtensionUnload failure on the
following bot:
>
https://uberchromegw.corp.google.com/i/chromium.win/builders/Win7%20Tests%20%...
> 
> Original issue's description:
> > Simplify ExtensionInstallChecker into a single-use class
> > 
> > ExtensionInstallChecker does asynchronous checks, and its set of checks
> > can be started more than once. This functionality isn't being used and
> > makes the class more complicated. Remove
> > ExtensionInstallChecker::ResetResults().
> > 
> > It's also unclear why the users of this class (CrxInstaller and
> > UnpackedInstaller) are intentionally storing their Profile and Extension
> > pointers in ExtensionInstallChecker class instead of remembering them
> > locally, so update that and remove
> > ExtensionInstallChecker::set_extension().
> > 
> > Lastly, allocate the ExtensionInstallChecker dynamically since we don't
> > always use it.
> > 
> > BUG=none
> > R=rdevlin.cronin@chromium.org
> > 
> > Review-Url: https://codereview.chromium.org/2751013002
> > Cr-Commit-Position: refs/heads/master@{#458883}
> > Committed:
https://chromium.googlesource.com/chromium/src/+/b24adc5bcbfde7fd67c6b23c3b07...
> 
> TBR=rdevlin.cronin@chromium.org,michaelpg@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=none
> 
> Review-Url: https://codereview.chromium.org/2769813004
> Cr-Commit-Position: refs/heads/master@{#458932}
> Committed:
https://chromium.googlesource.com/chromium/src/+/9cc4c29fd455f27d818bcca95934...

TBR=rdevlin.cronin@chromium.org,michaelpg@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=none

Review-Url: https://codereview.chromium.org/2766303003
Cr-Commit-Position: refs/heads/master@{#458955}
Committed:
https://chromium.googlesource.com/chromium/src/+/d741d25d04cbff8e7647d204a43d...
==========

[commit-bot: I haz the power, 2017-03-23 00:36:57]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/d741d25d04cbff8e7647d204a43d...