Revert of Simplify ExtensionInstallChecker into a single-use class

Revert of Simplify ExtensionInstallChecker into a single-use class (patchset #7 id:120001 of https://codereview.chromium.org/2751013002/ )

Reason for revert:
Speculative revert for ServiceWorkerTest.ServiceWorkerSuspensionOnExtensionUnload failure on the following bot:
https://uberchromegw.corp.google.com/i/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29/builds/58372

Original issue's description:
> Simplify ExtensionInstallChecker into a single-use class
> 
> ExtensionInstallChecker does asynchronous checks, and its set of checks
> can be started more than once. This functionality isn't being used and
> makes the class more complicated. Remove
> ExtensionInstallChecker::ResetResults().
> 
> It's also unclear why the users of this class (CrxInstaller and
> UnpackedInstaller) are intentionally storing their Profile and Extension
> pointers in ExtensionInstallChecker class instead of remembering them
> locally, so update that and remove
> ExtensionInstallChecker::set_extension().
> 
> Lastly, allocate the ExtensionInstallChecker dynamically since we don't
> always use it.
> 
> BUG=none
> R=rdevlin.cronin@chromium.org
> 
> Review-Url: https://codereview.chromium.org/2751013002
> Cr-Commit-Position: refs/heads/master@{#458883}
> Committed: https://chromium.googlesource.com/chromium/src/+/b24adc5bcbfde7fd67c6b23c3b0721610c77f63b

TBR=rdevlin.cronin@chromium.org,michaelpg@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=none

Review-Url: https://codereview.chromium.org/2769813004
Cr-Commit-Position: refs/heads/master@{#458932}
Committed: https://chromium.googlesource.com/chromium/src/+/9cc4c29fd455f27d818bcca95934a2da2332459e

[dgozman, 2017-03-22 23:33:38]

The CQ bit was checked by dgozman@chromium.org

[dgozman, 2017-03-22 23:33:39]

Created Revert of Simplify ExtensionInstallChecker into a single-use class

[commit-bot: I haz the power, 2017-03-22 23:34:40]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-22 23:36:30]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1490225618653170, "parent_rev":
"23f6a12fc807abff832a75e21d7d8df3f12e9949", "commit_rev":
"9cc4c29fd455f27d818bcca95934a2da2332459e"}

[commit-bot: I haz the power, 2017-03-22 23:37:12]

Description was changed from

==========
Revert of Simplify ExtensionInstallChecker into a single-use class (patchset #7
id:120001 of https://codereview.chromium.org/2751013002/ )

Reason for revert:
Speculative revert for
ServiceWorkerTest.ServiceWorkerSuspensionOnExtensionUnload failure on the
following bot:
https://uberchromegw.corp.google.com/i/chromium.win/builders/Win7%20Tests%20%...

Original issue's description:
> Simplify ExtensionInstallChecker into a single-use class
> 
> ExtensionInstallChecker does asynchronous checks, and its set of checks
> can be started more than once. This functionality isn't being used and
> makes the class more complicated. Remove
> ExtensionInstallChecker::ResetResults().
> 
> It's also unclear why the users of this class (CrxInstaller and
> UnpackedInstaller) are intentionally storing their Profile and Extension
> pointers in ExtensionInstallChecker class instead of remembering them
> locally, so update that and remove
> ExtensionInstallChecker::set_extension().
> 
> Lastly, allocate the ExtensionInstallChecker dynamically since we don't
> always use it.
> 
> BUG=none
> R=rdevlin.cronin@chromium.org
> 
> Review-Url: https://codereview.chromium.org/2751013002
> Cr-Commit-Position: refs/heads/master@{#458883}
> Committed:
https://chromium.googlesource.com/chromium/src/+/b24adc5bcbfde7fd67c6b23c3b07...

TBR=rdevlin.cronin@chromium.org,michaelpg@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=none
==========

to

==========
Revert of Simplify ExtensionInstallChecker into a single-use class (patchset #7
id:120001 of https://codereview.chromium.org/2751013002/ )

Reason for revert:
Speculative revert for
ServiceWorkerTest.ServiceWorkerSuspensionOnExtensionUnload failure on the
following bot:
https://uberchromegw.corp.google.com/i/chromium.win/builders/Win7%20Tests%20%...

Original issue's description:
> Simplify ExtensionInstallChecker into a single-use class
> 
> ExtensionInstallChecker does asynchronous checks, and its set of checks
> can be started more than once. This functionality isn't being used and
> makes the class more complicated. Remove
> ExtensionInstallChecker::ResetResults().
> 
> It's also unclear why the users of this class (CrxInstaller and
> UnpackedInstaller) are intentionally storing their Profile and Extension
> pointers in ExtensionInstallChecker class instead of remembering them
> locally, so update that and remove
> ExtensionInstallChecker::set_extension().
> 
> Lastly, allocate the ExtensionInstallChecker dynamically since we don't
> always use it.
> 
> BUG=none
> R=rdevlin.cronin@chromium.org
> 
> Review-Url: https://codereview.chromium.org/2751013002
> Cr-Commit-Position: refs/heads/master@{#458883}
> Committed:
https://chromium.googlesource.com/chromium/src/+/b24adc5bcbfde7fd67c6b23c3b07...

TBR=rdevlin.cronin@chromium.org,michaelpg@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=none

Review-Url: https://codereview.chromium.org/2769813004
Cr-Commit-Position: refs/heads/master@{#458932}
Committed:
https://chromium.googlesource.com/chromium/src/+/9cc4c29fd455f27d818bcca95934...
==========

[commit-bot: I haz the power, 2017-03-22 23:37:13]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/9cc4c29fd455f27d818bcca95934...

[dgozman, 2017-03-23 00:29:54]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2766303003/ by dgozman@chromium.org.

The reason for reverting is: The issue fixed itself without a revert..