Convert content ConnectionFilter to OnBindInterface

Convert content ConnectionFilter to OnBindInterface.

- This was a pretty viral change, sorry about the size.
  - Specifically, had to make all the *Host classes use 
    BindInterface() to request interfaces from their children, thus
    replacing their GetRemoteInterfaces() accessor with a 
    BindInterface() call.
- This also has to eliminate any use of service_manager::Connection 
  as an indicator of the lifetime of the connection, hence the
  introduction of child.mojom as a means of monitoring the lifetime
  of the renderer connection.
- I had to tweak the expectations of the EmbeddedWorkerInstance test
  as queuing order changed slightly with the new BindInterface mocking.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2766263009
Cr-Commit-Position: refs/heads/master@{#461826}
Committed: https://chromium.googlesource.com/chromium/src/+/a06f7d6c588c321df213d842c712e12ad6db7dec

[Ben Goodger (Google), 2017-03-24 22:47:40]

Description was changed from

==========
Convert content ConnectionFilter to OnBindInterface

BUG=
==========

to

==========
Convert content ConnectionFilter to OnBindInterface

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[Ben Goodger (Google), 2017-03-27 22:06:39]

The CQ bit was checked by ben@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-27 22:07:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-27 22:19:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-27 22:19:32]

Dry run: Try jobs failed on following builders:
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[Ben Goodger (Google), 2017-03-27 22:24:20]

The CQ bit was checked by ben@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-27 22:25:08]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-27 22:35:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-27 22:35:56]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[Ben Goodger (Google), 2017-03-28 04:28:52]

The CQ bit was checked by ben@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-28 04:29:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-28 04:40:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-28 04:40:28]

Dry run: Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[Ben Goodger (Google), 2017-03-28 05:10:55]

The CQ bit was checked by ben@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-28 05:11:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-28 05:21:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-28 05:21:10]

Dry run: Try jobs failed on following builders:
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Ben Goodger (Google), 2017-03-28 05:23:02]

The CQ bit was checked by ben@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-28 05:23:20]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-28 05:34:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-28 05:34:35]

Dry run: Try jobs failed on following builders:
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)

[Ben Goodger (Google), 2017-03-28 05:46:23]

The CQ bit was checked by ben@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-28 05:46:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-28 05:58:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-28 05:58:07]

Dry run: Try jobs failed on following builders:
  linux_site_isolation on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_site_isol...)

[Ben Goodger (Google), 2017-03-28 21:11:38]

The CQ bit was checked by ben@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-28 21:12:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-28 21:12:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-28 21:12:40]

Dry run: CQ has no permission to schedule in bucket
master.tryserver.chromium.linux

[Ben Goodger (Google), 2017-03-28 22:05:10]

The CQ bit was checked by ben@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-28 22:05:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-28 22:26:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-28 22:26:48]

Dry run: Try jobs failed on following builders:
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)

[Ben Goodger (Google), 2017-03-28 22:29:42]

The CQ bit was checked by ben@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-28 22:30:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-28 22:53:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-28 22:53:35]

Dry run: Try jobs failed on following builders:
  win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)

[Ben Goodger (Google), 2017-03-28 23:37:46]

The CQ bit was checked by ben@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-28 23:38:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-29 01:40:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-29 01:40:40]

Dry run: Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_TIMED_OUT, build hasn't
started yet, builder probably lacks capacity)

[Ben Goodger (Google), 2017-03-30 19:17:55]

The CQ bit was checked by ben@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-30 19:18:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-30 20:40:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-30 20:40:49]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[Ben Goodger (Google), 2017-03-30 22:43:59]

The CQ bit was checked by ben@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-30 22:44:52]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-30 22:51:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-30 22:51:04]

Dry run: Try jobs failed on following builders:
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  android_cronet on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_cron...)
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Ben Goodger (Google), 2017-03-30 22:58:18]

The CQ bit was checked by ben@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-30 22:59:40]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-31 00:16:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-31 00:16:36]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Ben Goodger (Google), 2017-03-31 20:48:20]

The CQ bit was checked by ben@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-31 20:49:10]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Ben Goodger (Google), 2017-03-31 20:49:46]

ben@chromium.org changed reviewers:
+ rockot@chromium.org, tsepez@chromium.org

[Ben Goodger (Google), 2017-03-31 20:49:48]

tsepez: child.mojom, *.json
rockot: *

[Ben Goodger (Google), 2017-03-31 20:50:40]

Description was changed from

==========
Convert content ConnectionFilter to OnBindInterface

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Convert content ConnectionFilter to OnBindInterface.

- This was a pretty viral change, sorry about the size.
- This also has to eliminate any use of service_manager::Connection as an
indicator of the lifetime of the connection, hence the introduction of
child.mojom as a means of monitoring the lifetime of the renderer connection.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[Tom Sepez, 2017-03-31 20:58:00]

mojom LGTM, nothing to see here, CC me on the followups.

[commit-bot: I haz the power, 2017-03-31 21:48:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-31 21:48:49]

Dry run: Try jobs failed on following builders:
  linux_site_isolation on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_site_isol...)

[Ben Goodger (Google), 2017-04-03 18:13:38]

The CQ bit was checked by ben@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-03 18:14:39]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-03 19:04:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-03 19:04:19]

Dry run: Try jobs failed on following builders:
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Ben Goodger (Google), 2017-04-03 20:05:05]

The CQ bit was checked by ben@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-03 20:05:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Ben Goodger (Google), 2017-04-03 21:10:36]

Description was changed from

==========
Convert content ConnectionFilter to OnBindInterface.

- This was a pretty viral change, sorry about the size.
- This also has to eliminate any use of service_manager::Connection as an
indicator of the lifetime of the connection, hence the introduction of
child.mojom as a means of monitoring the lifetime of the renderer connection.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Convert content ConnectionFilter to OnBindInterface.

- This was a pretty viral change, sorry about the size.
  - Specifically, had to make all the *Host classes use BindInterface() to
request interfaces from their children, thus replacing their
GetRemoteInterfaces() accessor with a BindInterface() call.
- This also has to eliminate any use of service_manager::Connection as an
indicator of the lifetime of the connection, hence the introduction of
child.mojom as a means of monitoring the lifetime of the renderer connection.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[Ben Goodger (Google), 2017-04-03 21:11:10]

Description was changed from

==========
Convert content ConnectionFilter to OnBindInterface.

- This was a pretty viral change, sorry about the size.
  - Specifically, had to make all the *Host classes use BindInterface() to
request interfaces from their children, thus replacing their
GetRemoteInterfaces() accessor with a BindInterface() call.
- This also has to eliminate any use of service_manager::Connection as an
indicator of the lifetime of the connection, hence the introduction of
child.mojom as a means of monitoring the lifetime of the renderer connection.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Convert content ConnectionFilter to OnBindInterface.

- This was a pretty viral change, sorry about the size.
  - Specifically, had to make all the *Host classes use 
    BindInterface() to request interfaces from their children, thus
    replacing their GetRemoteInterfaces() accessor with a 
    BindInterface() call.
- This also has to eliminate any use of service_manager::Connection 
  as an indicator of the lifetime of the connection, hence the
  introduction of child.mojom as a means of monitoring the lifetime
  of the renderer connection.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[commit-bot: I haz the power, 2017-04-03 21:25:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-03 21:25:07]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[Ben Goodger (Google), 2017-04-04 17:07:06]

The CQ bit was checked by ben@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-04 17:07:36]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Ben Goodger (Google), 2017-04-04 17:22:09]

Description was changed from

==========
Convert content ConnectionFilter to OnBindInterface.

- This was a pretty viral change, sorry about the size.
  - Specifically, had to make all the *Host classes use 
    BindInterface() to request interfaces from their children, thus
    replacing their GetRemoteInterfaces() accessor with a 
    BindInterface() call.
- This also has to eliminate any use of service_manager::Connection 
  as an indicator of the lifetime of the connection, hence the
  introduction of child.mojom as a means of monitoring the lifetime
  of the renderer connection.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Convert content ConnectionFilter to OnBindInterface.

- This was a pretty viral change, sorry about the size.
  - Specifically, had to make all the *Host classes use 
    BindInterface() to request interfaces from their children, thus
    replacing their GetRemoteInterfaces() accessor with a 
    BindInterface() call.
- This also has to eliminate any use of service_manager::Connection 
  as an indicator of the lifetime of the connection, hence the
  introduction of child.mojom as a means of monitoring the lifetime
  of the renderer connection.
- I had to tweak the expectations of the EmbeddedWorkerInstance test
  as queuing order changed slightly with the new BindInterface mocking.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[Ben Goodger (Google), 2017-04-04 18:19:29]

ben@chromium.org changed reviewers:
+ jam@chromium.org
- rockot@chromium.org

[Ben Goodger (Google), 2017-04-04 18:19:30]

-rockot,+jam (ken is ooo)

[commit-bot: I haz the power, 2017-04-04 19:11:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-04 19:11:32]

Dry run: This issue passed the CQ dry run.

[jam, 2017-04-04 20:06:12]

lgtm

[Ben Goodger (Google), 2017-04-04 20:32:54]

The CQ bit was checked by ben@chromium.org

[Ben Goodger (Google), 2017-04-04 20:32:54]

The patchset sent to the CQ was uploaded after l-g-t-m from tsepez@chromium.org
Link to the patchset: https://codereview.chromium.org/2766263009/#ps400001
(title: ".")

[commit-bot: I haz the power, 2017-04-04 20:33:42]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-04 20:49:01]

CQ is committing da patch.

Bot data: {"patchset_id": 400001, "attempt_start_ts": 1491337974103620,
"parent_rev": "edde5cf5f6805ca0396c763aa4a6ba807c804153", "commit_rev":
"a06f7d6c588c321df213d842c712e12ad6db7dec"}

[commit-bot: I haz the power, 2017-04-04 20:49:53]

Description was changed from

==========
Convert content ConnectionFilter to OnBindInterface.

- This was a pretty viral change, sorry about the size.
  - Specifically, had to make all the *Host classes use 
    BindInterface() to request interfaces from their children, thus
    replacing their GetRemoteInterfaces() accessor with a 
    BindInterface() call.
- This also has to eliminate any use of service_manager::Connection 
  as an indicator of the lifetime of the connection, hence the
  introduction of child.mojom as a means of monitoring the lifetime
  of the renderer connection.
- I had to tweak the expectations of the EmbeddedWorkerInstance test
  as queuing order changed slightly with the new BindInterface mocking.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Convert content ConnectionFilter to OnBindInterface.

- This was a pretty viral change, sorry about the size.
  - Specifically, had to make all the *Host classes use 
    BindInterface() to request interfaces from their children, thus
    replacing their GetRemoteInterfaces() accessor with a 
    BindInterface() call.
- This also has to eliminate any use of service_manager::Connection 
  as an indicator of the lifetime of the connection, hence the
  introduction of child.mojom as a means of monitoring the lifetime
  of the renderer connection.
- I had to tweak the expectations of the EmbeddedWorkerInstance test
  as queuing order changed slightly with the new BindInterface mocking.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2766263009
Cr-Commit-Position: refs/heads/master@{#461826}
Committed:
https://chromium.googlesource.com/chromium/src/+/a06f7d6c588c321df213d842c712...
==========

[commit-bot: I haz the power, 2017-04-04 20:49:55]

Committed patchset #21 (id:400001) as
https://chromium.googlesource.com/chromium/src/+/a06f7d6c588c321df213d842c712...