content/browser/service_worker/embedded_worker_instance_unittest.cc - Issue 2766263009: Convert content ConnectionFilter to OnBindInterface

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/service_worker/embedded_worker_instance_unittest.cc

Issue 2766263009: Convert content ConnectionFilter to OnBindInterface (Closed)

Patch Set: . Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/service_worker/embedded_worker_instance.cc ('k') | content/browser/service_worker/embedded_worker_test_helper.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/service_worker/embedded_worker_instance_unittest.cc

diff --git a/content/browser/service_worker/embedded_worker_instance_unittest.cc b/content/browser/service_worker/embedded_worker_instance_unittest.cc

index 2182ffa385d4851bd36bd16f4ddb048cb216ead8..a5f9a0add52dcccb8abfc14865540a92555a621d 100644

--- a/content/browser/service_worker/embedded_worker_instance_unittest.cc

+++ b/content/browser/service_worker/embedded_worker_instance_unittest.cc

@@ -692,11 +692,10 @@ TEST_F(EmbeddedWorkerInstanceTest, FailToSendStartIPC) {

base::RunLoop().RunUntilIdle();

// Worker should handle the failure of binding as detach.

- ASSERT_EQ(3u, events_.size());

+ ASSERT_EQ(2u, events_.size());

EXPECT_EQ(PROCESS_ALLOCATED, events_[0].type);

- EXPECT_EQ(START_WORKER_MESSAGE_SENT, events_[1].type);

- EXPECT_EQ(DETACHED, events_[2].type);

- EXPECT_EQ(EmbeddedWorkerStatus::STARTING, events_[2].status);

+ EXPECT_EQ(DETACHED, events_[1].type);

+ EXPECT_EQ(EmbeddedWorkerStatus::STARTING, events_[1].status);

}

class FailEmbeddedWorkerInstanceClientImpl