Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 2766263008: Revert: "Let SVGForeignObject's local SVG coordinates mean what it should" (Closed)

Created:
3 years, 9 months ago by pdr.
Modified:
3 years, 9 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3029
Project:
chromium
Visibility:
Public.

Description

Revert: "Let SVGForeignObject's local SVG coordinates mean what it should" This patch caused a hit testing regression with foreign objects. While the fix is not hard, we are going to roll out as a precaution (and merge to stable). This is a manual revert of https://crrev.com/f451d9b5de5a1b4691d60d8c74341ac8a466cf57 (commit number #435337) due to revert conflicts. BUG=704643 Review-Url: https://codereview.chromium.org/2767343003 Cr-Commit-Position: refs/heads/master@{#459330} (cherry picked from commit 0cfb512a4ae94e681bd10a15d93abd740f330e3e) Review-Url: https://codereview.chromium.org/2766263008 . Cr-Commit-Position: refs/branch-heads/3029@{#410} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} Committed: https://chromium.googlesource.com/chromium/src/+/d2985fdcc85cfbbbd4a6c8def3f8331190312be5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -31 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutObject.h View 1 chunk +5 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/layout/svg/LayoutSVGBlock.h View 3 chunks +4 lines, -13 lines 0 comments Download
M third_party/WebKit/Source/core/layout/svg/LayoutSVGBlock.cpp View 3 chunks +0 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/core/layout/svg/LayoutSVGForeignObject.h View 2 chunks +3 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/svg/LayoutSVGForeignObject.cpp View 1 chunk +7 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.cpp View 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 2 (1 generated)
pdr.
3 years, 9 months ago (2017-03-24 17:09:10 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
d2985fdcc85cfbbbd4a6c8def3f8331190312be5.

Powered by Google App Engine
This is Rietveld 408576698