Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1324)

Issue 2767343003: Revert: "Let SVGForeignObject's local SVG coordinates mean what it should" (Closed)

Created:
3 years, 9 months ago by pdr.
Modified:
3 years, 9 months ago
Reviewers:
Xianzhu
CC:
blink-reviews, blink-reviews-layout_chromium.org, blink-reviews-paint_chromium.org, chromium-reviews, dshwang, krit, eae+blinkwatch, fmalita+watch_chromium.org, fs, gyuyoung2, jchaffraix+rendering, kouhei+svg_chromium.org, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, pdr+svgwatchlist_chromium.org, rwlbuis, Stephen Chennney, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert: "Let SVGForeignObject's local SVG coordinates mean what it should" This patch caused a hit testing regression with foreign objects. While the fix is not hard, we are going to roll out as a precaution (and merge to stable). This is a manual revert of https://crrev.com/f451d9b5de5a1b4691d60d8c74341ac8a466cf57 (commit number #435337) due to revert conflicts. BUG=704643 Review-Url: https://codereview.chromium.org/2767343003 Cr-Commit-Position: refs/heads/master@{#459330} Committed: https://chromium.googlesource.com/chromium/src/+/0cfb512a4ae94e681bd10a15d93abd740f330e3e

Patch Set 1 #

Patch Set 2 : Rebaseline test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -31 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutObject.h View 1 chunk +5 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/layout/svg/LayoutSVGBlock.h View 3 chunks +4 lines, -13 lines 0 comments Download
M third_party/WebKit/Source/core/layout/svg/LayoutSVGBlock.cpp View 3 chunks +0 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/core/layout/svg/LayoutSVGForeignObject.h View 2 chunks +3 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/svg/LayoutSVGForeignObject.cpp View 1 chunk +7 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.cpp View 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 20 (13 generated)
pdr.
3 years, 9 months ago (2017-03-23 22:36:59 UTC) #5
Xianzhu
lgtm
3 years, 9 months ago (2017-03-23 22:39:17 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2767343003/1
3 years, 9 months ago (2017-03-23 22:41:39 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2767343003/1
3 years, 9 months ago (2017-03-23 22:42:51 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2767343003/20001
3 years, 9 months ago (2017-03-24 00:11:35 UTC) #16
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/0cfb512a4ae94e681bd10a15d93abd740f330e3e
3 years, 9 months ago (2017-03-24 01:35:56 UTC) #19
Xianzhu
3 years, 8 months ago (2017-03-27 20:27:02 UTC) #20
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2778873002/ by wangxianzhu@chromium.org.

The reason for reverting is: Just to create the initial version of reland. .

Powered by Google App Engine
This is Rietveld 408576698