Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Issue 2766233002: Revert of Add TabContainer to Showcase (Closed)

Created:
3 years, 9 months ago by lpromero
Modified:
3 years, 9 months ago
Reviewers:
edchin
CC:
chromium-reviews, marq+watch_chromium.org, lpromero+watch_chromium.org, ios-reviews_chromium.org, ios-reviews+showcase_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Add TabContainer to Showcase (patchset #2 id:20001 of https://codereview.chromium.org/2764063002/ ) Reason for revert: Caused internal bots failures. Original issue's description: > Add TabContainer to Showcase > > BUG=none > R=edchin@chromium.org > > Review-Url: https://codereview.chromium.org/2764063002 > Cr-Commit-Position: refs/heads/master@{#458679} > Committed: https://chromium.googlesource.com/chromium/src/+/4a3404fa73477039a8b9b21be0bc5a5e26d4b290 TBR=edchin@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=none Review-Url: https://codereview.chromium.org/2766233002 Cr-Commit-Position: refs/heads/master@{#458772} Committed: https://chromium.googlesource.com/chromium/src/+/96bce3e41fb2611184a4616cebc614bc037fa4c8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -216 lines) Patch
M ios/showcase/BUILD.gn View 2 chunks +0 lines, -3 lines 0 comments Download
M ios/showcase/core/showcase_model.mm View 3 chunks +8 lines, -18 lines 0 comments Download
M ios/showcase/suggestions/sc_suggestions_egtest.mm View 2 chunks +1 line, -4 lines 0 comments Download
D ios/showcase/tab/BUILD.gn View 1 chunk +0 lines, -33 lines 0 comments Download
D ios/showcase/tab/sc_bottom_toolbar_tab_coordinator.h View 1 chunk +0 lines, -15 lines 0 comments Download
D ios/showcase/tab/sc_bottom_toolbar_tab_coordinator.mm View 1 chunk +0 lines, -25 lines 0 comments Download
D ios/showcase/tab/sc_tab_egtest.mm View 1 chunk +0 lines, -37 lines 0 comments Download
D ios/showcase/tab/sc_top_toolbar_tab_coordinator.h View 1 chunk +0 lines, -15 lines 0 comments Download
D ios/showcase/tab/sc_top_toolbar_tab_coordinator.mm View 1 chunk +0 lines, -25 lines 0 comments Download
M ios/showcase/tab_grid/sc_tab_grid_egtest.mm View 2 chunks +0 lines, -3 lines 0 comments Download
M ios/showcase/test/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
D ios/showcase/test/showcase_matchers.h View 1 chunk +0 lines, -18 lines 0 comments Download
D ios/showcase/test/showcase_matchers.mm View 1 chunk +0 lines, -18 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
lpromero
Created Revert of Add TabContainer to Showcase
3 years, 9 months ago (2017-03-22 16:29:07 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2766233002/1
3 years, 9 months ago (2017-03-22 16:29:24 UTC) #3
commit-bot: I haz the power
3 years, 9 months ago (2017-03-22 16:31:06 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/96bce3e41fb2611184a4616cebc6...

Powered by Google App Engine
This is Rietveld 408576698