Add TabContainer to Showcase

Add TabContainer to Showcase

BUG=none
R=edchin@chromium.org

Review-Url: https://codereview.chromium.org/2764063002
Cr-Commit-Position: refs/heads/master@{#458679}
Committed: https://chromium.googlesource.com/chromium/src/+/4a3404fa73477039a8b9b21be0bc5a5e26d4b290

[lpromero, 2017-03-21 15:05:16]

The CQ bit was checked by lpromero@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-21 15:05:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-21 16:18:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-21 16:18:57]

Dry run: This issue passed the CQ dry run.

[edchin, 2017-03-21 17:04:21]

lgtm % one non-critical suggestion.

https://codereview.chromium.org/2764063002/diff/1/ios/showcase/test/showcase_...
File ios/showcase/test/showcase_matchers.mm (right):

https://codereview.chromium.org/2764063002/diff/1/ios/showcase/test/showcase_...
ios/showcase/test/showcase_matchers.mm:15: grey_kindOfClass([UILabel class]),
nil);
This matcher seems too generic. Is there some identifier that can be set/used?
Or perhaps match to a navigationItemView class (I don't know whether such a
class exists)?

[lpromero, 2017-03-21 22:41:59]

https://codereview.chromium.org/2764063002/diff/1/ios/showcase/test/showcase_...
File ios/showcase/test/showcase_matchers.mm (right):

https://codereview.chromium.org/2764063002/diff/1/ios/showcase/test/showcase_...
ios/showcase/test/showcase_matchers.mm:15: grey_kindOfClass([UILabel class]),
nil);
On 2017/03/21 17:04:20, edchin wrote:
> This matcher seems too generic. Is there some identifier that can be set/used?
> Or perhaps match to a navigationItemView class (I don't know whether such a
> class exists)?

I propose:
  return grey_kindOfClass(
      NSClassFromString(@"_UINavigationBarBackIndicatorView"));

Private class, but within tests, seems fine.

[edchin, 2017-03-21 23:06:05]

On 2017/03/21 22:41:59, lpromero wrote:
>
https://codereview.chromium.org/2764063002/diff/1/ios/showcase/test/showcase_...
> File ios/showcase/test/showcase_matchers.mm (right):
> 
>
https://codereview.chromium.org/2764063002/diff/1/ios/showcase/test/showcase_...
> ios/showcase/test/showcase_matchers.mm:15: grey_kindOfClass([UILabel class]),
> nil);
> On 2017/03/21 17:04:20, edchin wrote:
> > This matcher seems too generic. Is there some identifier that can be
set/used?
> > Or perhaps match to a navigationItemView class (I don't know whether such a
> > class exists)?
> 
> I propose:
>   return grey_kindOfClass(
>       NSClassFromString(@"_UINavigationBarBackIndicatorView"));
> 
> Private class, but within tests, seems fine.

sgtm.

[lpromero, 2017-03-21 23:33:00]

The CQ bit was checked by lpromero@chromium.org to run a CQ dry run

[lpromero, 2017-03-21 23:33:17]

The CQ bit was checked by lpromero@chromium.org

[lpromero, 2017-03-21 23:33:17]

The patchset sent to the CQ was uploaded after l-g-t-m from edchin@chromium.org
Link to the patchset: https://codereview.chromium.org/2764063002/#ps20001
(title: "Other heuristic for back button")

[commit-bot: I haz the power, 2017-03-21 23:33:58]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-22 00:13:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-22 00:13:39]

Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[lpromero, 2017-03-22 00:25:26]

The CQ bit was checked by lpromero@chromium.org

[commit-bot: I haz the power, 2017-03-22 00:26:17]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-22 01:36:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-22 01:36:39]

Try jobs failed on following builders:
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_TIMED_OUT,
build hasn't started yet, builder probably lacks capacity)

[lpromero, 2017-03-22 07:57:16]

The CQ bit was checked by lpromero@chromium.org

[commit-bot: I haz the power, 2017-03-22 07:57:31]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-22 08:01:30]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1490169436107090,
"parent_rev": "9fd79ea4e3ae8261ce5522d095577efdf4f58bc9", "commit_rev":
"4a3404fa73477039a8b9b21be0bc5a5e26d4b290"}

[commit-bot: I haz the power, 2017-03-22 08:02:11]

Description was changed from

==========
Add TabContainer to Showcase

BUG=none
R=edchin@chromium.org
==========

to

==========
Add TabContainer to Showcase

BUG=none
R=edchin@chromium.org

Review-Url: https://codereview.chromium.org/2764063002
Cr-Commit-Position: refs/heads/master@{#458679}
Committed:
https://chromium.googlesource.com/chromium/src/+/4a3404fa73477039a8b9b21be0bc...
==========

[commit-bot: I haz the power, 2017-03-22 08:02:12]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/4a3404fa73477039a8b9b21be0bc...

[lpromero, 2017-03-22 16:29:06]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2766233002/ by lpromero@chromium.org.

The reason for reverting is: Caused internal bots failures..