Add DocumentMarker::createCompositionMarker()

Add DocumentMarker::createCompositionMarker()

DocumentMarkerController refactor part 3: replace DocumentMarker's
Composition-specific constructor with a clearly-named createCompositionMarker()
method. Similar CLs for the other marker types to follow.

Depends on https://codereview.chromium.org/2763893002

BUG=

[rlanday, 2017-03-21 22:31:26]

The CQ bit was checked by rlanday@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-21 22:32:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[rlanday, 2017-03-21 22:37:14]

The CQ bit was checked by rlanday@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-21 22:38:03]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[rlanday, 2017-03-21 22:42:34]

rlanday@chromium.org changed reviewers:
+ yosin@chromium.org

[rlanday, 2017-03-21 22:42:34]

rlanday@chromium.org changed required reviewers:
+ yosin@chromium.org

[commit-bot: I haz the power, 2017-03-21 22:58:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-21 22:58:34]

Dry run: Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)

[rlanday, 2017-03-22 01:05:17]

The CQ bit was checked by rlanday@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-22 01:06:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-22 03:07:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-22 03:07:34]

Dry run: Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_TIMED_OUT, build hasn't
started yet, builder probably lacks capacity)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_TIMED_OUT,
build hasn't started yet, builder probably lacks capacity)

[yosin_UTC9, 2017-03-22 05:15:49]

https://codereview.chromium.org/2766003002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/editing/markers/DocumentMarker.h (right):

https://codereview.chromium.org/2766003002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/editing/markers/DocumentMarker.h:149:
DocumentMarker(MarkerType,
It seems this change doesn't relate to introduce
DocumentMarker::createCompositionMarker()

[rlanday, 2017-03-22 18:25:15]

https://codereview.chromium.org/2766003002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/editing/markers/DocumentMarker.h (right):

https://codereview.chromium.org/2766003002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/editing/markers/DocumentMarker.h:149:
DocumentMarker(MarkerType,
On 2017/03/22 at 05:15:49, yosin_UTC9 wrote:
> It seems this change doesn't relate to introduce
DocumentMarker::createCompositionMarker()

I need this private constructor to implement the create*Marker() methods. Do you
want this split off into a separate CL too? I feel like this is already small
enough.

[rlanday, 2017-03-22 18:27:30]

The CQ bit was checked by rlanday@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-22 18:28:10]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-22 18:43:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-22 18:43:58]

Dry run: Try jobs failed on following builders:
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)

[rlanday, 2017-03-22 19:43:24]

The CQ bit was checked by rlanday@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-22 19:44:24]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-22 21:14:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-22 21:14:46]

Dry run: This issue passed the CQ dry run.

[yosin_UTC9, 2017-03-23 06:04:39]

https://codereview.chromium.org/2766003002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/editing/markers/DocumentMarker.h (right):

https://codereview.chromium.org/2766003002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/editing/markers/DocumentMarker.h:149:
DocumentMarker(MarkerType,
On 2017/03/22 at 18:25:15, rlanday wrote:
> On 2017/03/22 at 05:15:49, yosin_UTC9 wrote:
> > It seems this change doesn't relate to introduce
DocumentMarker::createCompositionMarker()
> 
> I need this private constructor to implement the create*Marker() methods. Do
you want this split off into a separate CL too? I feel like this is already
small enough.

Yes, since this new constructor doesn't need for createCompositionMarker(), it
should be in another patch.
Isolation is another goal of making patch small in case of reverting and
bisecting.

[rlanday, 2017-03-29 01:44:57]

The CQ bit was checked by rlanday@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-29 01:45:40]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-29 03:47:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-29 03:47:18]

Dry run: Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_TIMED_OUT, build hasn't
started yet, builder probably lacks capacity)

[rlanday, 2017-03-29 23:14:37]

On 2017/03/23 at 06:04:39, yosin wrote:
>
https://codereview.chromium.org/2766003002/diff/40001/third_party/WebKit/Sour...
> File third_party/WebKit/Source/core/editing/markers/DocumentMarker.h (right):
> 
>
https://codereview.chromium.org/2766003002/diff/40001/third_party/WebKit/Sour...
> third_party/WebKit/Source/core/editing/markers/DocumentMarker.h:149:
DocumentMarker(MarkerType,
> On 2017/03/22 at 18:25:15, rlanday wrote:
> > On 2017/03/22 at 05:15:49, yosin_UTC9 wrote:
> > > It seems this change doesn't relate to introduce
DocumentMarker::createCompositionMarker()
> > 
> > I need this private constructor to implement the create*Marker() methods. Do
you want this split off into a separate CL too? I feel like this is already
small enough.
> 
> Yes, since this new constructor doesn't need for createCompositionMarker(), it
should be in another patch.
> Isolation is another goal of making patch small in case of reverting and
bisecting.

[rlanday, 2017-03-29 23:14:45]

Obsoleted by https://codereview.chromium.org/2723663002, closing