Add DocumentMarker::createCompositionMarker()

third_party/WebKit/Source/core/editing/markers/DocumentMarker.h

 /*
  * This file is part of the DOM implementation for WebCore.
  *
  * Copyright (C) 2006 Apple Computer, Inc.
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
  * version 2 of the License, or (at your option) any later version.
  *
@@ skipping 73 matching lines @@
   class MisspellingMarkers : public MarkerTypes {
    public:
     MisspellingMarkers() : MarkerTypes(Spelling | Grammar) {}
   };
 
   class SpellCheckClientMarkers : public MarkerTypes {
    public:
     SpellCheckClientMarkers() : MarkerTypes(Spelling | Grammar) {}
   };
 
+  static DocumentMarker* createCompositionMarker(unsigned startOffset,
+                                                 unsigned endOffset,
+                                                 Color underlineColor,
+                                                 bool thick,
+                                                 Color backgroundColor);
+
   DocumentMarker(MarkerType,
                  unsigned startOffset,
                  unsigned endOffset,
                  const String& description);
   DocumentMarker(unsigned startOffset, unsigned endOffset, bool activeMatch);
-  DocumentMarker(unsigned startOffset,
-                 unsigned endOffset,
-                 Color underlineColor,
-                 bool thick,
-                 Color backgroundColor);
 
   DocumentMarker(const DocumentMarker&);
 
   MarkerType type() const { return m_type; }
   unsigned startOffset() const { return m_startOffset; }
   unsigned endOffset() const { return m_endOffset; }
 
   const String& description() const;
   bool activeMatch() const;
   Color underlineColor() const;
@@ skipping 24 matching lines @@
   bool operator==(const DocumentMarker& o) const {
     return type() == o.type() && startOffset() == o.startOffset() &&
            endOffset() == o.endOffset();
   }
 
   bool operator!=(const DocumentMarker& o) const { return !(*this == o); }
 
   DECLARE_TRACE();
 
  private:
+  DocumentMarker(MarkerType,

[yosin_UTC9, 2017/03/22 05:15:49]

It seems this change doesn't relate to introduce
DocumentMarker::createCompositionMarker()

[rlanday, 2017/03/22 18:25:15]

I need this private constructor to implement the create*Marker() methods. Do you
want this split off into a separate CL too? I feel like this is already small
enough.

[yosin_UTC9, 2017/03/23 06:04:39]

Yes, since this new constructor doesn't need for createCompositionMarker(), it
should be in another patch.
Isolation is another goal of making patch small in case of reverting and
bisecting.

+                 unsigned startOffset,
+                 unsigned endOffset,
+                 DocumentMarkerDetails*);
+
   MarkerType m_type;
   unsigned m_startOffset;
   unsigned m_endOffset;
   Member<DocumentMarkerDetails> m_details;
 };
 
 using DocumentMarkerVector = HeapVector<Member<DocumentMarker>>;
 
 inline DocumentMarkerDetails* DocumentMarker::details() const {
   return m_details.get();
 }
 
 class DocumentMarkerDetails
     : public GarbageCollectedFinalized<DocumentMarkerDetails> {
  public:
   DocumentMarkerDetails() {}
   virtual ~DocumentMarkerDetails();
   virtual bool isDescription() const { return false; }
   virtual bool isTextMatch() const { return false; }
   virtual bool isComposition() const { return false; }
 
   DEFINE_INLINE_VIRTUAL_TRACE() {}
 };
 
 }  // namespace blink
 
 #endif  // DocumentMarker_h