third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.cpp - Issue 2766003002: Add DocumentMarker::createCompositionMarker()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.cpp

Issue 2766003002: Add DocumentMarker::createCompositionMarker() (Closed)

Patch Set: Rebase Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/editing/markers/DocumentMarker.cpp ('k') | third_party/WebKit/Source/core/editing/markers/DocumentMarkerListTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.cpp

diff --git a/third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.cpp b/third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.cpp

index aab6aebd02efde231634dc324bff117ad697d85d..43b62e539b09018f0b3edc0c86d5539b6dbfd9a9 100644

--- a/third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.cpp

+++ b/third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.cpp

@@ -103,9 +103,10 @@ void DocumentMarkerController::addCompositionMarker(const Position& start,

for (TextIterator markedText(start, end); !markedText.atEnd();

markedText.advance()) {

addMarker(markedText.currentContainer(),

- new DocumentMarker(markedText.startOffsetInCurrentContainer(),

- markedText.endOffsetInCurrentContainer(),

- underlineColor, thick, backgroundColor));

+ DocumentMarker::createCompositionMarker(

+ markedText.startOffsetInCurrentContainer(),

+ markedText.endOffsetInCurrentContainer(), underlineColor,

+ thick, backgroundColor));

}