Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 2765963002: Revert of Making the Mojo Channel Messages legacy mode dynamic. (patchset #4 id:120001 of https://c… (Closed)

Created:
3 years, 9 months ago by stevenjb
Modified:
3 years, 9 months ago
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3047
Project:
chromium
Visibility:
Public.

Description

Revert of Making the Mojo Channel Messages legacy mode dynamic. (patchset #4 id:120001 of https://codereview.chromium.org/2749853003/ ) Reason for revert: Breaks the Chrome PFQ bot. Will need to sync with a change to the Arc++ code before landing this. Original issue's description: > Making the Mojo Channel Messages legacy mode dynamic. > > The mojo::edk::Channel::Message class uses a compile flag to determine > whether to use the legacy or normal mode (legacy mode is used to keep > backward compatibility between Arc++ and ChromeOS). > Making that flag dynamically set on the embedder so that the default is > now normal mode on Android. This is going to be used for adding > Parcelable support on mojo Android (where we'll need the normal > Message's header to include the parcelables). > > BUG=699311 > > Review-Url: https://codereview.chromium.org/2749853003 > Cr-Commit-Position: refs/heads/master@{#457549} > Committed: https://chromium.googlesource.com/chromium/src/+/f2be81a465a7b2ef07b3667f83de1009206acace TBR=rockot@chromium.org BUG=699311 Review-Url: https://codereview.chromium.org/2765673002 Cr-Commit-Position: refs/heads/master@{#458271} (cherry picked from commit 8726a7e2f31aba4bec3de517134e3c8edc512349) Review-Url: https://codereview.chromium.org/2765963002 . Cr-Commit-Position: refs/branch-heads/3047@{#5} Cr-Branched-From: 15ae1e89e749d6443b6caffdbc78ad24f945aa67-refs/heads/master@{#458255} Committed: https://chromium.googlesource.com/chromium/src/+/4f4e58bed74a0d5023a5668d68bcad7343212964

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -30 lines) Patch
M mojo/edk/embedder/embedder.h View 1 chunk +0 lines, -7 lines 0 comments Download
M mojo/edk/embedder/embedder.cc View 3 chunks +1 line, -8 lines 0 comments Download
M mojo/edk/system/channel.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/edk/system/channel.cc View 4 chunks +7 lines, -14 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
stevenjb
Committed patchset #1 (id:1) manually as 4f4e58bed74a0d5023a5668d68bcad7343212964.
3 years, 9 months ago (2017-03-21 19:49:23 UTC) #2
Ken Rockot(use gerrit already)
3 years, 9 months ago (2017-03-21 19:51:25 UTC) #3
Message was sent while issue was closed.
On 2017/03/21 at 19:49:23, stevenjb wrote:
> Committed patchset #1 (id:1) manually as
4f4e58bed74a0d5023a5668d68bcad7343212964.

Ah, for the branch. I was confused at first, because this was already reverted
on ToT. Thanks!

Powered by Google App Engine
This is Rietveld 408576698