Chromium Code Reviews
DescriptionRevert of Making the Mojo Channel Messages legacy mode dynamic. (patchset #4 id:120001 of https://codereview.chromium.org/2749853003/ )
Reason for revert:
Breaks the Chrome PFQ bot. Will need to sync with a change to the Arc++ code before landing this.
Original issue's description:
> Making the Mojo Channel Messages legacy mode dynamic.
>
> The mojo::edk::Channel::Message class uses a compile flag to determine
> whether to use the legacy or normal mode (legacy mode is used to keep
> backward compatibility between Arc++ and ChromeOS).
> Making that flag dynamically set on the embedder so that the default is
> now normal mode on Android. This is going to be used for adding
> Parcelable support on mojo Android (where we'll need the normal
> Message's header to include the parcelables).
>
> BUG=699311
>
> Review-Url: https://codereview.chromium.org/2749853003
> Cr-Commit-Position: refs/heads/master@{#457549}
> Committed: https://chromium.googlesource.com/chromium/src/+/f2be81a465a7b2ef07b3667f83de1009206acace
TBR=rockot@chromium.org
BUG=699311
Review-Url: https://codereview.chromium.org/2765673002
Cr-Commit-Position: refs/heads/master@{#458271}
(cherry picked from commit 8726a7e2f31aba4bec3de517134e3c8edc512349)
Review-Url: https://codereview.chromium.org/2765963002 .
Cr-Commit-Position: refs/branch-heads/3047@{#5}
Cr-Branched-From: 15ae1e89e749d6443b6caffdbc78ad24f945aa67-refs/heads/master@{#458255}
Committed: https://chromium.googlesource.com/chromium/src/+/4f4e58bed74a0d5023a5668d68bcad7343212964
Patch Set 1 #
Messages
Total messages: 3 (1 generated)
|
||||||||||||||||||||||||||||||||||||||||||||||