Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(270)

Issue 2765673002: Revert of Making the Mojo Channel Messages legacy mode dynamic. (Closed)

Created:
3 years, 9 months ago by Jay Civelli
Modified:
3 years, 9 months ago
CC:
Aaron Boodman, abarth-chromium, chromium-reviews, darin (slow to review), darin-cc_chromium.org, jam, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Making the Mojo Channel Messages legacy mode dynamic. (patchset #4 id:120001 of https://codereview.chromium.org/2749853003/ ) Reason for revert: Breaks the Chrome PFQ bot. Will need to sync with a change to the Arc++ code before landing this. Original issue's description: > Making the Mojo Channel Messages legacy mode dynamic. > > The mojo::edk::Channel::Message class uses a compile flag to determine > whether to use the legacy or normal mode (legacy mode is used to keep > backward compatibility between Arc++ and ChromeOS). > Making that flag dynamically set on the embedder so that the default is > now normal mode on Android. This is going to be used for adding > Parcelable support on mojo Android (where we'll need the normal > Message's header to include the parcelables). > > BUG=699311 > > Review-Url: https://codereview.chromium.org/2749853003 > Cr-Commit-Position: refs/heads/master@{#457549} > Committed: https://chromium.googlesource.com/chromium/src/+/f2be81a465a7b2ef07b3667f83de1009206acace TBR=rockot@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=699311 Review-Url: https://codereview.chromium.org/2765673002 Cr-Commit-Position: refs/heads/master@{#458271} Committed: https://chromium.googlesource.com/chromium/src/+/8726a7e2f31aba4bec3de517134e3c8edc512349

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -30 lines) Patch
M mojo/edk/embedder/embedder.h View 1 chunk +0 lines, -7 lines 0 comments Download
M mojo/edk/embedder/embedder.cc View 2 chunks +1 line, -8 lines 0 comments Download
M mojo/edk/system/channel.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/edk/system/channel.cc View 4 chunks +7 lines, -14 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Jay Civelli
Created Revert of Making the Mojo Channel Messages legacy mode dynamic.
3 years, 9 months ago (2017-03-21 00:07:13 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2765673002/1
3 years, 9 months ago (2017-03-21 00:08:06 UTC) #3
commit-bot: I haz the power
3 years, 9 months ago (2017-03-21 01:44:27 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/8726a7e2f31aba4bec3de517134e...

Powered by Google App Engine
This is Rietveld 408576698