Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Issue 2765873002: Revert of Disable WebNavigationApiTest.CrossProcessFragment and CrossProcessHistory (Closed)

Created:
3 years, 9 months ago by nasko
Modified:
3 years, 9 months ago
Reviewers:
horo
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Disable WebNavigationApiTest.CrossProcessFragment and CrossProcessHistory (patchset #1 id:1 of https://codereview.chromium.org/2760303002/ ) Reason for revert: These tests failed only once in build 35616 and not at all until build 35626 had them universally disabled. They weren't flaky before that either, so I don't see a reason for them to be disabled. https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%281%29 Original issue's description: > Disable WebNavigationApiTest.CrossProcessFragment and CrossProcessHistory > > TBR=nasko@chromium.org > BUG=703546 > > Review-Url: https://codereview.chromium.org/2760303002 > Cr-Commit-Position: refs/heads/master@{#458352} > Committed: https://chromium.googlesource.com/chromium/src/+/b490646f85e530c3bc7aa5e75157b43c130b1853 TBR=horo@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=703546 Review-Url: https://codereview.chromium.org/2765873002 Cr-Commit-Position: refs/heads/master@{#458392} Committed: https://chromium.googlesource.com/chromium/src/+/c6a42a48ee0441ffd5fe674217122c6d5a58b893

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -4 lines) Patch
M chrome/browser/extensions/api/web_navigation/web_navigation_apitest.cc View 2 chunks +2 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
nasko
Created Revert of Disable WebNavigationApiTest.CrossProcessFragment and CrossProcessHistory
3 years, 9 months ago (2017-03-21 13:48:38 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2765873002/1
3 years, 9 months ago (2017-03-21 13:49:01 UTC) #3
commit-bot: I haz the power
3 years, 9 months ago (2017-03-21 13:51:05 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/c6a42a48ee0441ffd5fe67421712...

Powered by Google App Engine
This is Rietveld 408576698