Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(568)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2760303002: Disable WebNavigationApiTest.CrossProcessFragment and CrossProcessHistory (Closed)

Created:
3 years, 9 months ago by horo
Modified:
3 years, 9 months ago
Reviewers:
nasko
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable WebNavigationApiTest.CrossProcessFragment and CrossProcessHistory TBR=nasko@chromium.org BUG=703546 Review-Url: https://codereview.chromium.org/2760303002 Cr-Commit-Position: refs/heads/master@{#458352} Committed: https://chromium.googlesource.com/chromium/src/+/b490646f85e530c3bc7aa5e75157b43c130b1853

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M chrome/browser/extensions/api/web_navigation/web_navigation_apitest.cc View 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2760303002/1
3 years, 9 months ago (2017-03-21 08:07:08 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/b490646f85e530c3bc7aa5e75157b43c130b1853
3 years, 9 months ago (2017-03-21 08:49:25 UTC) #5
nasko
3 years, 9 months ago (2017-03-21 13:48:37 UTC) #6
Message was sent while issue was closed. 
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2765873002/ by nasko@chromium.org.

The reason for reverting is: These tests failed only once in build 35616 and not
at all until build 35626 had them universally disabled. They weren't flaky
before that either, so I don't see a reason for them to be disabled.

https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%....

Powered by Google App Engine
This is Rietveld 408576698