Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(328)

Issue 2765783002: Restrict Navigator.getInstalledRelatedApps() to secure contexts. (Closed)

Created:
3 years, 9 months ago by Timothy Loh
Modified:
3 years, 9 months ago
Reviewers:
Matt Giuca
CC:
chromium-reviews, blink-reviews, haraken, chrome-apps-syd-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Restrict Navigator.getInstalledRelatedApps() to secure contexts. This patch adds to Navigator.getInstalledRelatedApps() the IDL attribute [SecureContext], restricting the function to secure contexts. The explainer for getInstalledRelatedApps() states that it "only works with sites using HTTPS." https://github.com/WICG/get-installed-related-apps/blob/master/EXPLAINER.md BUG=703477 Review-Url: https://codereview.chromium.org/2765783002 Cr-Commit-Position: refs/heads/master@{#458327} Committed: https://chromium.googlesource.com/chromium/src/+/1d2d74238c94507cfd774ccb3b50626c9f89c9cf

Patch Set 1 #

Patch Set 2 : fix copypaste #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -1 line) Patch
A third_party/WebKit/LayoutTests/http/tests/security/powerfulFeatureRestrictions/get-installed-related-apps-on-insecure-origin.html View 1 1 chunk +15 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/installedapp/NavigatorInstalledApp.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/installedapp/NavigatorInstalledApp.idl View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (10 generated)
Timothy Loh
3 years, 9 months ago (2017-03-21 04:32:39 UTC) #6
Matt Giuca
lgtm, thanks!
3 years, 9 months ago (2017-03-21 04:39:49 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2765783002/20001
3 years, 9 months ago (2017-03-21 06:28:28 UTC) #11
commit-bot: I haz the power
3 years, 9 months ago (2017-03-21 06:34:19 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/1d2d74238c94507cfd774ccb3b50...

Powered by Google App Engine
This is Rietveld 408576698