third_party/WebKit/Source/modules/installedapp/NavigatorInstalledApp.cpp - Issue 2765783002: Restrict Navigator.getInstalledRelatedApps() to secure contexts.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/installedapp/NavigatorInstalledApp.cpp

Issue 2765783002: Restrict Navigator.getInstalledRelatedApps() to secure contexts. (Closed)

Patch Set: fix copypaste Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/http/tests/security/powerfulFeatureRestrictions/get-installed-related-apps-on-insecure-origin.html ('k') | third_party/WebKit/Source/modules/installedapp/NavigatorInstalledApp.idl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/installedapp/NavigatorInstalledApp.cpp

diff --git a/third_party/WebKit/Source/modules/installedapp/NavigatorInstalledApp.cpp b/third_party/WebKit/Source/modules/installedapp/NavigatorInstalledApp.cpp

index 88b692443fd2b63097fad0bd609f4c477cb840a0..f95d791768c0da5a4396b726d80fd4679931f21e 100644

--- a/third_party/WebKit/Source/modules/installedapp/NavigatorInstalledApp.cpp

+++ b/third_party/WebKit/Source/modules/installedapp/NavigatorInstalledApp.cpp

@@ -44,6 +44,8 @@ NavigatorInstalledApp& NavigatorInstalledApp::from(Navigator& navigator) {

ScriptPromise NavigatorInstalledApp::getInstalledRelatedApps(

ScriptState* scriptState,

Navigator& navigator) {

+ // [SecureContext] from the IDL ensures this.

+ DCHECK(scriptState->getExecutionContext()->isSecureContext());

return NavigatorInstalledApp::from(navigator).getInstalledRelatedApps(

scriptState);

}