Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(178)

Issue 2765703003: Include display names in Quirks URL (Closed)

Created:
3 years, 9 months ago by Greg Levin
Modified:
3 years, 9 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3029
Project:
chromium
Visibility:
Public.

Description

Include display names in Quirks URL BUG=667416 TEST=Enable VLOGing for Quirks, plug in an external display, check log, verify that Quirks URL includes display name (roughly the same name as seen in display settings for 2nd monitor). Review-Url: https://codereview.chromium.org/2746443002 Cr-Commit-Position: refs/heads/master@{#457551} (cherry picked from commit 2aa9dd13b0ba68a0f493c86f80b1bb0f3ceffc41) Review-Url: https://codereview.chromium.org/2765703003 . Cr-Commit-Position: refs/branch-heads/3029@{#335} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} Committed: https://chromium.googlesource.com/chromium/src/+/6430db27258ef171500a8e58c82a24459ccefd0f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -10 lines) Patch
M ash/display/display_color_manager_chromeos.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/display/quirks_browsertest.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/policy/device_quirks_policy_browsertest.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M components/quirks/quirks_client.h View 2 chunks +4 lines, -0 lines 0 comments Download
M components/quirks/quirks_client.cc View 4 chunks +10 lines, -3 lines 0 comments Download
M components/quirks/quirks_manager.h View 2 chunks +2 lines, -0 lines 0 comments Download
M components/quirks/quirks_manager.cc View 4 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Greg Levin
3 years, 9 months ago (2017-03-21 17:10:03 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
6430db27258ef171500a8e58c82a24459ccefd0f.

Powered by Google App Engine
This is Rietveld 408576698