Include display names in Quirks URL

Include display names in Quirks URL

BUG=667416
TEST=Enable VLOGing for Quirks, plug in an external display, check log,
verify that Quirks URL includes display name (roughly the same name as
seen in display settings for 2nd monitor).

Review-Url: https://codereview.chromium.org/2746443002
Cr-Commit-Position: refs/heads/master@{#457551}
Committed: https://chromium.googlesource.com/chromium/src/+/2aa9dd13b0ba68a0f493c86f80b1bb0f3ceffc41

[Greg Levin, 2017-03-09 16:46:55]

glevin@chromium.org changed reviewers:
+ oshima@chromium.org

[Greg Levin, 2017-03-09 16:46:56]

Please have a look!

[oshima, 2017-03-14 12:38:54]

https://codereview.chromium.org/2746443002/diff/1/chrome/browser/chromeos/dis...
File chrome/browser/chromeos/display/quirks_browsertest.cc (right):

https://codereview.chromium.org/2746443002/diff/1/chrome/browser/chromeos/dis...
chrome/browser/chromeos/display/quirks_browsertest.cc:68: product_id, "",
nit: std::string()

https://codereview.chromium.org/2746443002/diff/1/components/quirks/quirks_cl...
File components/quirks/quirks_client.h (right):

https://codereview.chromium.org/2746443002/diff/1/components/quirks/quirks_cl...
components/quirks/quirks_client.h:29: std::string display_name,
nit: const &

https://codereview.chromium.org/2746443002/diff/1/components/quirks/quirks_ma...
File components/quirks/quirks_manager.cc (right):

https://codereview.chromium.org/2746443002/diff/1/components/quirks/quirks_ma...
components/quirks/quirks_manager.cc:117: std::string display_name,
ditto

https://codereview.chromium.org/2746443002/diff/1/components/quirks/quirks_ma...
components/quirks/quirks_manager.cc:165: std::string display_name,
ditto

https://codereview.chromium.org/2746443002/diff/1/components/quirks/quirks_ma...
File components/quirks/quirks_manager.h (right):

https://codereview.chromium.org/2746443002/diff/1/components/quirks/quirks_ma...
components/quirks/quirks_manager.h:95: std::string display_name,
ditto

https://codereview.chromium.org/2746443002/diff/1/components/quirks/quirks_ma...
components/quirks/quirks_manager.h:129: std::string display_name,
ditto

[Greg Levin, 2017-03-14 21:36:58]

Done... please have another look!

https://codereview.chromium.org/2746443002/diff/1/chrome/browser/chromeos/dis...
File chrome/browser/chromeos/display/quirks_browsertest.cc (right):

https://codereview.chromium.org/2746443002/diff/1/chrome/browser/chromeos/dis...
chrome/browser/chromeos/display/quirks_browsertest.cc:68: product_id, "",
On 2017/03/14 12:38:54, oshima wrote:
> nit: std::string()

Done.

https://codereview.chromium.org/2746443002/diff/1/components/quirks/quirks_cl...
File components/quirks/quirks_client.cc (right):

https://codereview.chromium.org/2746443002/diff/1/components/quirks/quirks_cl...
components/quirks/quirks_client.cc:58: std::string display_name,
Ditto / Done

https://codereview.chromium.org/2746443002/diff/1/components/quirks/quirks_cl...
File components/quirks/quirks_client.h (right):

https://codereview.chromium.org/2746443002/diff/1/components/quirks/quirks_cl...
components/quirks/quirks_client.h:29: std::string display_name,
On 2017/03/14 12:38:54, oshima wrote:
> nit: const &

Done.

https://codereview.chromium.org/2746443002/diff/1/components/quirks/quirks_ma...
File components/quirks/quirks_manager.cc (right):

https://codereview.chromium.org/2746443002/diff/1/components/quirks/quirks_ma...
components/quirks/quirks_manager.cc:117: std::string display_name,
On 2017/03/14 12:38:54, oshima wrote:
> ditto

Done.

https://codereview.chromium.org/2746443002/diff/1/components/quirks/quirks_ma...
components/quirks/quirks_manager.cc:165: std::string display_name,
On 2017/03/14 12:38:54, oshima wrote:
> ditto

Done.

https://codereview.chromium.org/2746443002/diff/1/components/quirks/quirks_ma...
File components/quirks/quirks_manager.h (right):

https://codereview.chromium.org/2746443002/diff/1/components/quirks/quirks_ma...
components/quirks/quirks_manager.h:95: std::string display_name,
On 2017/03/14 12:38:54, oshima wrote:
> ditto

Done.

https://codereview.chromium.org/2746443002/diff/1/components/quirks/quirks_ma...
components/quirks/quirks_manager.h:129: std::string display_name,
On 2017/03/14 12:38:54, oshima wrote:
> ditto

Done.

[oshima, 2017-03-16 20:28:20]

lgtm

[Greg Levin, 2017-03-16 20:29:25]

The CQ bit was checked by glevin@chromium.org

[commit-bot: I haz the power, 2017-03-16 20:29:51]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-16 21:08:03]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1489696165904820,
"parent_rev": "d67295ebc58b086ac493e26fe8e4498c09ffc21e", "commit_rev":
"2aa9dd13b0ba68a0f493c86f80b1bb0f3ceffc41"}

[commit-bot: I haz the power, 2017-03-16 21:08:47]

Description was changed from

==========
Include display names in Quirks URL

BUG=667416
TEST=Enable VLOGing for Quirks, plug in an external display, check log,
verify that Quirks URL includes display name (roughly the same name as
seen in display settings for 2nd monitor).
==========

to

==========
Include display names in Quirks URL

BUG=667416
TEST=Enable VLOGing for Quirks, plug in an external display, check log,
verify that Quirks URL includes display name (roughly the same name as
seen in display settings for 2nd monitor).

Review-Url: https://codereview.chromium.org/2746443002
Cr-Commit-Position: refs/heads/master@{#457551}
Committed:
https://chromium.googlesource.com/chromium/src/+/2aa9dd13b0ba68a0f493c86f80b1...
==========

[commit-bot: I haz the power, 2017-03-16 21:08:47]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/2aa9dd13b0ba68a0f493c86f80b1...