Remove a level of indirection in HTMLCollection.

Remove a level of indirection in HTMLCollection.

It's not necessary to give HeapVector a separate allocation (itself, it's
only a pointer and two integers). Fixing this requires us to make the code
const-correct. While here, it's easy to replace repeated push_back with
appendVector, which is more efficient.

Review-Url: https://codereview.chromium.org/2765653002
Cr-Commit-Position: refs/heads/master@{#458496}
Committed: https://chromium.googlesource.com/chromium/src/+/0f1cedecb0e3586a32ed44d5064f82ff8f8eac5f

[jbroman, 2017-03-20 23:52:56]

The CQ bit was checked by jbroman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-20 23:53:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-21 02:39:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-21 02:39:51]

Dry run: This issue passed the CQ dry run.

[jbroman, 2017-03-21 13:58:48]

jbroman@chromium.org changed reviewers:
+ tkent@chromium.org

[jbroman, 2017-03-21 13:58:48]

Not important, but spotted a pointer-to-vector use and thought it might be
simpler this way. WDYT?

[dglazkov, 2017-03-21 14:34:45]

dglazkov@chromium.org changed reviewers:
+ dglazkov@chromium.org

[dglazkov, 2017-03-21 14:34:45]

lgtm

[jbroman, 2017-03-21 18:47:25]

The CQ bit was checked by jbroman@chromium.org

[commit-bot: I haz the power, 2017-03-21 18:48:04]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-21 18:58:15]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1490122045823010, "parent_rev":
"863711a1f0b27b5aa30ed18af6932eae19ccf5fc", "commit_rev":
"0f1cedecb0e3586a32ed44d5064f82ff8f8eac5f"}

[commit-bot: I haz the power, 2017-03-21 18:58:59]

Description was changed from

==========
Remove a level of indirection in HTMLCollection.

It's not necessary to give HeapVector a separate allocation (itself, it's
only a pointer and two integers). Fixing this requires us to make the code
const-correct. While here, it's easy to replace repeated push_back with
appendVector, which is more efficient.
==========

to

==========
Remove a level of indirection in HTMLCollection.

It's not necessary to give HeapVector a separate allocation (itself, it's
only a pointer and two integers). Fixing this requires us to make the code
const-correct. While here, it's easy to replace repeated push_back with
appendVector, which is more efficient.

Review-Url: https://codereview.chromium.org/2765653002
Cr-Commit-Position: refs/heads/master@{#458496}
Committed:
https://chromium.googlesource.com/chromium/src/+/0f1cedecb0e3586a32ed44d5064f...
==========

[commit-bot: I haz the power, 2017-03-21 18:59:00]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/0f1cedecb0e3586a32ed44d5064f...