Remove a level of indirection in HTMLCollection.

third_party/WebKit/Source/core/html/HTMLCollection.cpp

 /*
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 1999 Antti Koivisto (koivisto@kde.org)
  * Copyright (C) 2003-2008, 2011, 2012, 2014 Apple Inc. All rights reserved.
  * Copyright (C) 2014 Samsung Electronics. All rights reserved.
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
  * version 2 of the License, or (at your option) any later version.
@@ skipping 401 matching lines @@
 
 Element* HTMLCollection::namedItem(const AtomicString& name) const {
   // http://msdn.microsoft.com/workshop/author/dhtml/reference/methods/nameditem.asp
   // This method first searches for an object with a matching id
   // attribute. If a match is not found, the method then searches for an
   // object with a matching name attribute, but only on those elements
   // that are allowed a name attribute.
   updateIdNameCache();
 
   const NamedItemCache& cache = namedItemCache();
-  HeapVector<Member<Element>>* idResults = cache.getElementsById(name);
+  const auto* idResults = cache.getElementsById(name);
   if (idResults && !idResults->isEmpty())
     return idResults->front();
 
-  HeapVector<Member<Element>>* nameResults = cache.getElementsByName(name);
+  const auto* nameResults = cache.getElementsByName(name);
   if (nameResults && !nameResults->isEmpty())
     return nameResults->front();
 
   return nullptr;
 }
 
 bool HTMLCollection::namedPropertyQuery(const AtomicString& name,
                                         ExceptionState&) {
   return namedItem(name);
 }
@@ skipping 67 matching lines @@
 
 void HTMLCollection::namedItems(const AtomicString& name,
                                 HeapVector<Member<Element>>& result) const {
   DCHECK(result.isEmpty());
   if (name.isEmpty())
     return;
 
   updateIdNameCache();
 
   const NamedItemCache& cache = namedItemCache();
-  if (HeapVector<Member<Element>>* idResults = cache.getElementsById(name)) {
-    for (const auto& element : *idResults)
-      result.push_back(element);
-  }
-  if (HeapVector<Member<Element>>* nameResults =
-          cache.getElementsByName(name)) {
-    for (const auto& element : *nameResults)
-      result.push_back(element);
-  }
+  if (const auto* idResults = cache.getElementsById(name))
+    result.appendVector(*idResults);
+  if (const auto* nameResults = cache.getElementsByName(name))
+    result.appendVector(*nameResults);
 }
 
 HTMLCollection::NamedItemCache::NamedItemCache() {}
 
 DEFINE_TRACE(HTMLCollection) {
   visitor->trace(m_namedItemCache);
   visitor->trace(m_collectionItemsCache);
   LiveNodeListBase::trace(visitor);
 }
 
 }  // namespace blink