Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1504)

Issue 2765643002: Revert of PlzNavigate: send SourceLocation when mixed content is found (Closed)

Created:
3 years, 9 months ago by Dmitry Titov
Modified:
3 years, 9 months ago
Reviewers:
clamy, Nate Chapin, jam, nasko
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, creis+watch_chromium.org, nasko+codewatch_chromium.org, jam, dglazkov+blink, darin-cc_chromium.org, blink-reviews, kinuko+watch, blink-reviews-api_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of PlzNavigate: send SourceLocation when mixed content is found (patchset #8 id:140001 of https://codereview.chromium.org/2745363004/ ) Reason for revert: This enabled LayoutTests which started to fail: https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Mac10.11%20%28dbg%29/builds/7963 https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Mac10.11%20%28dbg%29/builds/7964 https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Mac10.11%20%28dbg%29/builds/7965 There are text failures and a DCHECK: 14:48:10.177 5284 worker/2 virtual/mojo-loading/http/tests/serviceworker/chromium/request-body-blob-crash.html crashed, (stderr lines): 14:48:10.177 5284 [9083:38659:0320/144810.106602:2775098818460:FATAL:url_request.cc(1205)] Check failed: blocked_by_.empty(). Original issue's description: > PlzNavigate: send SourceLocation when mixed content is found > > This CL adds SourceLocation information to the IPC > FrameMsg_MixedContentFound so that Mixed Contents console error messages > display the appropriate line number. It also fixes an issue due to the > rebase of https://codereview.chromium.org/2720763002/, where the > SourceLocation information was not properly copied in the pending > navigation info in RenderFrameImpl. > > BUG=695072 > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation > > Review-Url: https://codereview.chromium.org/2745363004 > Cr-Commit-Position: refs/heads/master@{#458068} > Committed: https://chromium.googlesource.com/chromium/src/+/8a58df54d52b781b9628e7adee559157a8602150 TBR=nasko@chromium.org,japhet@chromium.org,jam@chromium.org,clamy@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=695072 Review-Url: https://codereview.chromium.org/2765643002 Cr-Commit-Position: refs/heads/master@{#458245} Committed: https://chromium.googlesource.com/chromium/src/+/54c5f4ac7707c8e5d5341eae008fa5f303f7656c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -99 lines) Patch
M content/browser/frame_host/mixed_content_navigation_throttle.cc View 1 chunk +3 lines, -9 lines 0 comments Download
M content/browser/frame_host/navigation_handle_impl.h View 2 chunks +0 lines, -10 lines 0 comments Download
M content/browser/frame_host/navigation_request.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M content/common/frame_messages.h View 2 chunks +6 lines, -11 lines 0 comments Download
M content/renderer/render_frame_impl.h View 3 chunks +15 lines, -5 lines 0 comments Download
M content/renderer/render_frame_impl.cc View 3 chunks +9 lines, -23 lines 0 comments Download
M third_party/WebKit/LayoutTests/FlagExpectations/enable-browser-side-navigation View 1 chunk +8 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/loader/MixedContentChecker.h View 3 chunks +2 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/loader/MixedContentChecker.cpp View 4 chunks +6 lines, -14 lines 0 comments Download
M third_party/WebKit/Source/web/WebLocalFrameImpl.h View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/web/WebLocalFrameImpl.cpp View 1 chunk +5 lines, -12 lines 0 comments Download
M third_party/WebKit/public/web/WebLocalFrame.h View 2 chunks +1 line, -3 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Dmitry Titov
Created Revert of PlzNavigate: send SourceLocation when mixed content is found
3 years, 9 months ago (2017-03-20 23:49:26 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2765643002/1
3 years, 9 months ago (2017-03-20 23:50:00 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/54c5f4ac7707c8e5d5341eae008fa5f303f7656c
3 years, 9 months ago (2017-03-20 23:53:12 UTC) #6
Dmitry Titov
3 years, 9 months ago (2017-03-21 04:53:30 UTC) #7
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2760263002/ by dimich@chromium.org.

The reason for reverting is: Turns out this patch was not the reason for those
failures. Re-landing it back..

Powered by Google App Engine
This is Rietveld 408576698