PlzNavigate: send SourceLocation when mixed content is found

PlzNavigate: send SourceLocation when mixed content is found

This CL adds SourceLocation information to the IPC
FrameMsg_MixedContentFound so that Mixed Contents console error messages
display the appropriate line number. It also fixes an issue due to the
rebase of https://codereview.chromium.org/2720763002/, where the
SourceLocation information was not properly copied in the pending
navigation info in RenderFrameImpl.

BUG=695072
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2745363004
Cr-Commit-Position: refs/heads/master@{#458068}
Committed: https://chromium.googlesource.com/chromium/src/+/8a58df54d52b781b9628e7adee559157a8602150

[clamy, 2017-03-15 16:57:05]

Description was changed from

==========
PlzNavigate: send SourceLocation when mixed content is found

This CL adds SourceLocation information to the IPC
FrameMsg_MixedContentFound so that Mixed Contents console error messages
display the appropriate line number. It also fixes an issue due to the
rebase of https://codereview.chromium.org/2720763002/, where the
SourceLocation information was not properly copied in the pending
navigation info in RenderFrameImpl.

BUG=695072
==========

to

==========
PlzNavigate: send SourceLocation when mixed content is found

This CL adds SourceLocation information to the IPC
FrameMsg_MixedContentFound so that Mixed Contents console error messages
display the appropriate line number. It also fixes an issue due to the
rebase of https://codereview.chromium.org/2720763002/, where the
SourceLocation information was not properly copied in the pending
navigation info in RenderFrameImpl.

BUG=695072
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[clamy, 2017-03-15 16:57:12]

The CQ bit was checked by clamy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-15 16:57:44]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[clamy, 2017-03-15 16:57:51]

Description was changed from

==========
PlzNavigate: send SourceLocation when mixed content is found

This CL adds SourceLocation information to the IPC
FrameMsg_MixedContentFound so that Mixed Contents console error messages
display the appropriate line number. It also fixes an issue due to the
rebase of https://codereview.chromium.org/2720763002/, where the
SourceLocation information was not properly copied in the pending
navigation info in RenderFrameImpl.

BUG=695072
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
PlzNavigate: send SourceLocation when mixed content is found

This CL adds SourceLocation information to the IPC
FrameMsg_MixedContentFound so that Mixed Contents console error messages
display the appropriate line number. It also fixes an issue due to the
rebase of https://codereview.chromium.org/2720763002/, where the
SourceLocation information was not properly copied in the pending
navigation info in RenderFrameImpl.

BUG=695072
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[clamy, 2017-03-15 16:57:52]

clamy@chromium.org changed reviewers:
+ japhet@chromium.org, nasko@chromium.org

[clamy, 2017-03-15 16:58:05]

@nasko, japhet: PTAL

[commit-bot: I haz the power, 2017-03-15 18:15:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-15 18:15:39]

Dry run: This issue passed the CQ dry run.

[nasko, 2017-03-15 18:29:08]

content/ LGTM with some nits.

https://codereview.chromium.org/2745363004/diff/1/content/browser/frame_host/...
File content/browser/frame_host/navigation_handle_impl.h (right):

https://codereview.chromium.org/2745363004/diff/1/content/browser/frame_host/...
content/browser/frame_host/navigation_handle_impl.h:529: // Information about
the Javascript that started the navigation. for
nit: JavaScript
nit: For

https://codereview.chromium.org/2745363004/diff/1/content/renderer/render_fra...
File content/renderer/render_frame_impl.h (right):

https://codereview.chromium.org/2745363004/diff/1/content/renderer/render_fra...
content/renderer/render_frame_impl.h:1408: blink::WebSourceLocation location;
nit: source_location, otherwise it reads a bit too closely to a url location.

[clamy, 2017-03-16 15:06:47]

The CQ bit was checked by clamy@chromium.org to run a CQ dry run

[clamy, 2017-03-16 15:07:03]

@japhet: PTAL

https://codereview.chromium.org/2745363004/diff/1/content/browser/frame_host/...
File content/browser/frame_host/navigation_handle_impl.h (right):

https://codereview.chromium.org/2745363004/diff/1/content/browser/frame_host/...
content/browser/frame_host/navigation_handle_impl.h:529: // Information about
the Javascript that started the navigation. for
On 2017/03/15 18:29:08, nasko (slow) wrote:
> nit: JavaScript
> nit: For

Done.

https://codereview.chromium.org/2745363004/diff/1/content/renderer/render_fra...
File content/renderer/render_frame_impl.h (right):

https://codereview.chromium.org/2745363004/diff/1/content/renderer/render_fra...
content/renderer/render_frame_impl.h:1408: blink::WebSourceLocation location;
On 2017/03/15 18:29:08, nasko (slow) wrote:
> nit: source_location, otherwise it reads a bit too closely to a url location.

Done.

[commit-bot: I haz the power, 2017-03-16 15:07:20]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-16 16:34:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-16 16:34:29]

Dry run: This issue passed the CQ dry run.

[Nate Chapin, 2017-03-16 19:54:12]

LGTM w/nit

https://codereview.chromium.org/2745363004/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/loader/MixedContentChecker.cpp (right):

https://codereview.chromium.org/2745363004/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/loader/MixedContentChecker.cpp:235: if
(!sourceLocation) {
Nit: invert this if() so it doesn't have the '!', since we're handling both the
null and non-null cases?

[clamy, 2017-03-17 13:17:34]

Thanks!

https://codereview.chromium.org/2745363004/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/loader/MixedContentChecker.cpp (right):

https://codereview.chromium.org/2745363004/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/loader/MixedContentChecker.cpp:235: if
(!sourceLocation) {
On 2017/03/16 19:54:12, Nate Chapin wrote:
> Nit: invert this if() so it doesn't have the '!', since we're handling both
the
> null and non-null cases?

Done.

[clamy, 2017-03-17 13:17:40]

The CQ bit was checked by clamy@chromium.org

[clamy, 2017-03-17 13:17:40]

The patchset sent to the CQ was uploaded after l-g-t-m from nasko@chromium.org,
japhet@chromium.org
Link to the patchset: https://codereview.chromium.org/2745363004/#ps80001
(title: "Addressed nit")

[commit-bot: I haz the power, 2017-03-17 13:17:49]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-17 14:47:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-17 14:47:18]

Failed to apply patch for content/browser/frame_host/navigation_handle_impl.h:
While running git apply --index -p1;
  error: patch failed: content/browser/frame_host/navigation_handle_impl.h:359
  error: content/browser/frame_host/navigation_handle_impl.h: patch does not
apply

Patch:       content/browser/frame_host/navigation_handle_impl.h
Index: content/browser/frame_host/navigation_handle_impl.h
diff --git a/content/browser/frame_host/navigation_handle_impl.h
b/content/browser/frame_host/navigation_handle_impl.h
index
8372a46a37a1bb6eb2a5e1ce7ab6b402887c5fca..8e36696ad06cf6115f775436bc0d939d94115dc9
100644
--- a/content/browser/frame_host/navigation_handle_impl.h
+++ b/content/browser/frame_host/navigation_handle_impl.h
@@ -359,6 +359,11 @@ class CONTENT_EXPORT NavigationHandleImpl : public
NavigationHandle {
     base_url_for_data_url_ = url;
   }
 
+  const SourceLocation& source_location() const { return source_location_; }
+  void set_source_location(const SourceLocation& source_location) {
+    source_location_ = source_location;
+  }
+
  private:
   friend class NavigationHandleImplTest;
 
@@ -525,6 +530,11 @@ class CONTENT_EXPORT NavigationHandleImpl : public
NavigationHandle {
   net::HostPortPair socket_address_;
   NavigationType navigation_type_;
 
+  // PlzNavigate
+  // Information about the JavaScript that started the navigation. For
+  // navigations initiated by Javascript.
+  SourceLocation source_location_;
+
   base::WeakPtrFactory<NavigationHandleImpl> weak_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(NavigationHandleImpl);

[clamy, 2017-03-17 15:33:14]

The CQ bit was checked by clamy@chromium.org

[clamy, 2017-03-17 15:33:15]

The patchset sent to the CQ was uploaded after l-g-t-m from japhet@chromium.org,
nasko@chromium.org
Link to the patchset: https://codereview.chromium.org/2745363004/#ps100001
(title: "Rebase")

[commit-bot: I haz the power, 2017-03-17 15:33:44]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[clamy, 2017-03-17 15:54:00]

The CQ bit was unchecked by clamy@chromium.org

[clamy, 2017-03-17 16:29:43]

The CQ bit was checked by clamy@chromium.org

[clamy, 2017-03-17 16:29:44]

The patchset sent to the CQ was uploaded after l-g-t-m from japhet@chromium.org,
nasko@chromium.org
Link to the patchset: https://codereview.chromium.org/2745363004/#ps120001
(title: "Rebase")

[commit-bot: I haz the power, 2017-03-17 16:29:52]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-17 17:53:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-17 17:53:25]

Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[jam, 2017-03-18 03:19:10]

The CQ bit was checked by jam@chromium.org

[commit-bot: I haz the power, 2017-03-18 03:19:30]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-18 03:24:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-18 03:24:06]

Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[clamy, 2017-03-20 10:47:30]

The CQ bit was checked by clamy@chromium.org

[clamy, 2017-03-20 10:47:31]

The patchset sent to the CQ was uploaded after l-g-t-m from japhet@chromium.org,
nasko@chromium.org
Link to the patchset: https://codereview.chromium.org/2745363004/#ps140001
(title: "Rebase")

[commit-bot: I haz the power, 2017-03-20 10:47:39]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-20 13:33:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-20 13:33:38]

Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[clamy, 2017-03-20 14:34:41]

The CQ bit was checked by clamy@chromium.org

[commit-bot: I haz the power, 2017-03-20 14:34:58]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-20 15:27:25]

CQ is committing da patch.

Bot data: {"patchset_id": 140001, "attempt_start_ts": 1490020481315900,
"parent_rev": "576e9b3d5a185c7daa2a9ccde1ae51350fd218d3", "commit_rev":
"8a58df54d52b781b9628e7adee559157a8602150"}

[commit-bot: I haz the power, 2017-03-20 15:28:31]

Description was changed from

==========
PlzNavigate: send SourceLocation when mixed content is found

This CL adds SourceLocation information to the IPC
FrameMsg_MixedContentFound so that Mixed Contents console error messages
display the appropriate line number. It also fixes an issue due to the
rebase of https://codereview.chromium.org/2720763002/, where the
SourceLocation information was not properly copied in the pending
navigation info in RenderFrameImpl.

BUG=695072
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
PlzNavigate: send SourceLocation when mixed content is found

This CL adds SourceLocation information to the IPC
FrameMsg_MixedContentFound so that Mixed Contents console error messages
display the appropriate line number. It also fixes an issue due to the
rebase of https://codereview.chromium.org/2720763002/, where the
SourceLocation information was not properly copied in the pending
navigation info in RenderFrameImpl.

BUG=695072
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2745363004
Cr-Commit-Position: refs/heads/master@{#458068}
Committed:
https://chromium.googlesource.com/chromium/src/+/8a58df54d52b781b9628e7adee55...
==========

[commit-bot: I haz the power, 2017-03-20 15:28:32]

Committed patchset #8 (id:140001) as
https://chromium.googlesource.com/chromium/src/+/8a58df54d52b781b9628e7adee55...

[Dmitry Titov, 2017-03-20 23:49:25]

A revert of this CL (patchset #8 id:140001) has been created in
https://codereview.chromium.org/2765643002/ by dimich@chromium.org.

The reason for reverting is: This enabled LayoutTests which started to fail:

https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Mac1...
https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Mac1...
https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Mac1...

There are text failures and a DCHECK:
14:48:10.177 5284 worker/2
virtual/mojo-loading/http/tests/serviceworker/chromium/request-body-blob-crash.html
crashed, (stderr lines):
14:48:10.177 5284  
[9083:38659:0320/144810.106602:2775098818460:FATAL:url_request.cc(1205)] Check
failed: blocked_by_.empty(). .