[sql] Import SQLite 3.17.0.

[sql] Import SQLite 3.17.0.

[Re-lands https://codereview.chromium.org/2751253002/ with a fix for
Linux clang compile.]

Ran through the import script in third_party/sqlite/README.Chromium,
including the SQLite test suite.  No new errors observed.

SQLite changes are at http://www.sqlite.org/changes.html , Chromium
previously used 3.10.2.

All patches were applied and the results reviewed to make sure
backported patches were safe to remove, and retained patches were still
covering what was necessary.  I also tried to test the cases which have
failed in previous imports.

Keep fts4 disabled, and also the new fts3 virtual table and unicode61
tokenizer.  Once enabled, these are very hard to disable, and there
doesn't seem to be any pressure to enable them.  Other SQLITE_* flags
were reviewed for applicability, none looked essential.

BUG=701518
TBR=michaeln@chromium.org

Review-Url: https://codereview.chromium.org/2765553002 .
Cr-Commit-Position: refs/heads/master@{#458151}
Committed: https://chromium.googlesource.com/chromium/src/+/0270407c0555655d204235d1fa39c86d453cb809

[Scott Hess - ex-Googler, 2017-03-20 19:34:51]

Description was changed from

==========
[sql] Import SQLite 3.17.0.

[Re-lands https://codereview.chromium.org/2751253002/ with a fix for
Linux clang compile.]

Ran through the import script in third_party/sqlite/README.Chromium,
including the SQLite test suite.  No new errors observed.

SQLite changes are at http://www.sqlite.org/changes.html , Chromium
previously used 3.10.2.

All patches were applied and the results reviewed to make sure
backported patches were safe to remove, and retained patches were still
covering what was necessary.  I also tried to test the cases which have
failed in previous imports.

Keep fts4 disabled, and also the new fts3 virtual table and unicode61
tokenizer.  Once enabled, these are very hard to disable, and there
doesn't seem to be any pressure to enable them.  Other SQLITE_* flags
were reviewed for applicability, none looked essential.

BUG=701518
==========

to

==========
[sql] Import SQLite 3.17.0.

[Re-lands https://codereview.chromium.org/2751253002/ with a fix for
Linux clang compile.]

Ran through the import script in third_party/sqlite/README.Chromium,
including the SQLite test suite.  No new errors observed.

SQLite changes are at http://www.sqlite.org/changes.html , Chromium
previously used 3.10.2.

All patches were applied and the results reviewed to make sure
backported patches were safe to remove, and retained patches were still
covering what was necessary.  I also tried to test the cases which have
failed in previous imports.

Keep fts4 disabled, and also the new fts3 virtual table and unicode61
tokenizer.  Once enabled, these are very hard to disable, and there
doesn't seem to be any pressure to enable them.  Other SQLITE_* flags
were reviewed for applicability, none looked essential.

BUG=701518
TBR=michaeln@chromium.org
==========

[Scott Hess - ex-Googler, 2017-03-20 19:35:25]

shess@chromium.org changed reviewers:
+ michaeln@chromium.org

[Scott Hess - ex-Googler, 2017-03-20 19:35:30]

Since the previous change bounced due to hard-to-forsee build issues, I'm going
to reland (manually, again, sigh) with TBR.

https://codereview.chromium.org/2765553002/diff/1/third_party/sqlite/patches/...
File
third_party/sqlite/patches/0010-build-Undefined-symbol-in-intrinsic-on-clang.patch
(right):

https://codereview.chromium.org/2765553002/diff/1/third_party/sqlite/patches/...
third_party/sqlite/patches/0010-build-Undefined-symbol-in-intrinsic-on-clang.patch:30:
+     (!defined(__linux__) || !defined(__i386__)))
Apologies, I forgot to upload the unpatched version, but git-cl-patch can't
patch the original version in.  So the diff is the addition of the last line
(Linux+i386) to the clang clause, then I reformatted the statement due to line
length.

[Scott Hess - ex-Googler, 2017-03-20 19:38:43]

Description was changed from

==========
[sql] Import SQLite 3.17.0.

[Re-lands https://codereview.chromium.org/2751253002/ with a fix for
Linux clang compile.]

Ran through the import script in third_party/sqlite/README.Chromium,
including the SQLite test suite.  No new errors observed.

SQLite changes are at http://www.sqlite.org/changes.html , Chromium
previously used 3.10.2.

All patches were applied and the results reviewed to make sure
backported patches were safe to remove, and retained patches were still
covering what was necessary.  I also tried to test the cases which have
failed in previous imports.

Keep fts4 disabled, and also the new fts3 virtual table and unicode61
tokenizer.  Once enabled, these are very hard to disable, and there
doesn't seem to be any pressure to enable them.  Other SQLITE_* flags
were reviewed for applicability, none looked essential.

BUG=701518
TBR=michaeln@chromium.org
==========

to

==========
[sql] Import SQLite 3.17.0.

[Re-lands https://codereview.chromium.org/2751253002/ with a fix for
Linux clang compile.]

Ran through the import script in third_party/sqlite/README.Chromium,
including the SQLite test suite.  No new errors observed.

SQLite changes are at http://www.sqlite.org/changes.html , Chromium
previously used 3.10.2.

All patches were applied and the results reviewed to make sure
backported patches were safe to remove, and retained patches were still
covering what was necessary.  I also tried to test the cases which have
failed in previous imports.

Keep fts4 disabled, and also the new fts3 virtual table and unicode61
tokenizer.  Once enabled, these are very hard to disable, and there
doesn't seem to be any pressure to enable them.  Other SQLITE_* flags
were reviewed for applicability, none looked essential.

BUG=701518
TBR=michaeln@chromium.org

Review-Url: https://codereview.chromium.org/2765553002 .
Cr-Commit-Position: refs/heads/master@{#458151}
Committed:
https://chromium.googlesource.com/chromium/src/+/0270407c0555655d204235d1fa39...
==========

[Scott Hess - ex-Googler, 2017-03-20 19:38:46]

Committed patchset #1 (id:1) manually as
0270407c0555655d204235d1fa39c86d453cb809.

[lmilko, 2017-03-21 09:31:58]

On 2017/03/20 19:38:46, Scott Hess wrote:
> Committed patchset #1 (id:1) manually as
> 0270407c0555655d204235d1fa39c86d453cb809.

Chromium Linux 32b is still broken for architectures other then i386.

For example mips32:

http://www.rt-rk.com/mips-buildbot/builders/build_and_test_chromium_trunk_for...

Condition:

(!defined(__linux__) || !defined(__i386__))

will no stop ARM or MIPS from calling __builtin_mul_overflow

[Scott Hess - ex-Googler, 2017-03-21 16:26:52]

On 2017/03/21 09:31:58, lmilko wrote:
> On 2017/03/20 19:38:46, Scott Hess wrote:
> > Committed patchset #1 (id:1) manually as
> > 0270407c0555655d204235d1fa39c86d453cb809.
> 
> Chromium Linux 32b is still broken for architectures other then i386.
> 
> For example mips32:
> 
>
http://www.rt-rk.com/mips-buildbot/builders/build_and_test_chromium_trunk_for...
> 
> Condition:
> 
> (!defined(__linux__) || !defined(__i386__))
> 
> will no stop ARM or MIPS from calling __builtin_mul_overflow

http://crbug.com/701524 is about simply dropping the clang clause, because maybe
it's just a clang bug and I don't want to spend the rest of my life extending
that #if.  Let me know if there are other things broken (though letting me know
in the form of a patch may be best, as I have no idea where to start for testing
mips).

[Scott Hess - ex-Googler, 2017-03-21 18:24:00]

On 2017/03/21 16:26:52, Scott Hess wrote:
> On 2017/03/21 09:31:58, lmilko wrote:
> > On 2017/03/20 19:38:46, Scott Hess wrote:
> > > Committed patchset #1 (id:1) manually as
> > > 0270407c0555655d204235d1fa39c86d453cb809.
> > 
> > Chromium Linux 32b is still broken for architectures other then i386.
> > 
> > For example mips32:
> > 
> >
>
http://www.rt-rk.com/mips-buildbot/builders/build_and_test_chromium_trunk_for...
> > 
> > Condition:
> > 
> > (!defined(__linux__) || !defined(__i386__))
> > 
> > will no stop ARM or MIPS from calling __builtin_mul_overflow
> 
> http://crbug.com/701524 is about simply dropping the clang clause, because
maybe
> it's just a clang bug and I don't want to spend the rest of my life extending
> that #if.  Let me know if there are other things broken (though letting me
know
> in the form of a patch may be best, as I have no idea where to start for
testing
> mips).

BTW, the fix for that other bug has landed, as of
9e39ce92107b239f0043d55eef91e155b1471382 or commit position #458457, so pile on
if it's not fixing things on your end.

[lmilko, 2017-03-22 08:40:45]

On 2017/03/21 18:24:00, Scott Hess wrote:
> On 2017/03/21 16:26:52, Scott Hess wrote:
> > On 2017/03/21 09:31:58, lmilko wrote:
> > > On 2017/03/20 19:38:46, Scott Hess wrote:
> > > > Committed patchset #1 (id:1) manually as
> > > > 0270407c0555655d204235d1fa39c86d453cb809.
> > > 
> > > Chromium Linux 32b is still broken for architectures other then i386.
> > > 
> > > For example mips32:
> > > 
> > >
> >
>
http://www.rt-rk.com/mips-buildbot/builders/build_and_test_chromium_trunk_for...
> > > 
> > > Condition:
> > > 
> > > (!defined(__linux__) || !defined(__i386__))
> > > 
> > > will no stop ARM or MIPS from calling __builtin_mul_overflow
> > 
> > http://crbug.com/701524 is about simply dropping the clang clause, because
> maybe
> > it's just a clang bug and I don't want to spend the rest of my life
extending
> > that #if.  Let me know if there are other things broken (though letting me
> know
> > in the form of a patch may be best, as I have no idea where to start for
> testing
> > mips).
> 
> BTW, the fix for that other bug has landed, as of
> 9e39ce92107b239f0043d55eef91e155b1471382 or commit position #458457, so pile
on
> if it's not fixing things on your end.

#458457 did fix the issue for mips, thanks.