Moving FileDescriptorInfo from content/ to base/.

Moving FileDescriptorInfo from content/ to base/ and making base
multiprocess test client use this class (instead of their own version).

BUG=702316
Review-Url: https://codereview.chromium.org/2765453004
Cr-Commit-Position: refs/heads/master@{#458568}
Committed: https://chromium.googlesource.com/chromium/src/+/d62ca1238e8c477dfbbbe928febfa67dd19bfe35

[Jay Civelli, 2017-03-20 19:04:01]

The CQ bit was checked by jcivelli@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-20 19:05:03]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-20 19:17:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-20 19:17:49]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[Jay Civelli, 2017-03-20 19:31:16]

Patchset #1 (id:1) has been deleted

[Jay Civelli, 2017-03-20 19:31:30]

Patchset #1 (id:20001) has been deleted

[Jay Civelli, 2017-03-20 19:31:36]

Patchset #1 (id:40001) has been deleted

[Jay Civelli, 2017-03-20 19:31:44]

The CQ bit was checked by jcivelli@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-20 19:32:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Jay Civelli, 2017-03-20 19:33:49]

Description was changed from

==========
Moving FileDescriptorInfo from content/ to base/.

BUG=702316
==========

to

==========
Moving FileDescriptorInfo from content/ to base/ and making base
multiprocess test client use this class (instead of their own version).

BUG=702316
==========

[Jay Civelli, 2017-03-20 19:33:49]

jcivelli@chromium.org changed reviewers:
+ boliu@chromium.org

[Jay Civelli, 2017-03-20 19:40:11]

The CQ bit was checked by jcivelli@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-20 19:40:53]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-20 19:49:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-20 19:49:40]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Jay Civelli, 2017-03-20 20:01:22]

Patchset #1 (id:60001) has been deleted

[Jay Civelli, 2017-03-20 20:27:16]

jcivelli@chromium.org changed reviewers:
+ agrieve@chromium.org

[boliu, 2017-03-20 20:46:16]

lgtm

[agrieve, 2017-03-21 00:16:51]

lgtm

https://codereview.chromium.org/2765453004/diff/80001/base/BUILD.gn
File base/BUILD.gn (right):

https://codereview.chromium.org/2765453004/diff/80001/base/BUILD.gn#newcode2515
base/BUILD.gn:2515:
"android/java/src/org/chromium/base/process_launcher/ChildProcessCreationParams.java",
nit: move this down beside the other one.

[Jay Civelli, 2017-03-21 00:34:06]

jcivelli@chromium.org changed reviewers:
+ jbudorick@chromium.org

[Jay Civelli, 2017-03-21 00:39:31]

jcivelli@chromium.org changed reviewers:
+ tsepez@chromium.org

[Jay Civelli, 2017-03-21 00:40:29]

Adding jbudorick@ for base/test OWNERS review.
Adding tsepez@ for security OWNERS review.

Thanks.

https://codereview.chromium.org/2765453004/diff/80001/base/BUILD.gn
File base/BUILD.gn (right):

https://codereview.chromium.org/2765453004/diff/80001/base/BUILD.gn#newcode2515
base/BUILD.gn:2515:
"android/java/src/org/chromium/base/process_launcher/ChildProcessCreationParams.java",
On 2017/03/21 00:16:51, agrieve wrote:
> nit: move this down beside the other one.

Done.

[Jay Civelli, 2017-03-21 00:41:07]

The CQ bit was checked by jcivelli@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-21 00:41:43]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jbudorick, 2017-03-21 00:44:50]

On 2017/03/21 00:40:29, Jay Civelli wrote:
> Adding jbudorick@ for base/test OWNERS review.

lgtm

> Adding tsepez@ for security OWNERS review.
> 
> Thanks.
> 
> https://codereview.chromium.org/2765453004/diff/80001/base/BUILD.gn
> File base/BUILD.gn (right):
> 
>
https://codereview.chromium.org/2765453004/diff/80001/base/BUILD.gn#newcode2515
> base/BUILD.gn:2515:
>
"android/java/src/org/chromium/base/process_launcher/ChildProcessCreationParams.java",
> On 2017/03/21 00:16:51, agrieve wrote:
> > nit: move this down beside the other one.
> 
> Done.

[commit-bot: I haz the power, 2017-03-21 00:54:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-21 00:54:48]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Tom Sepez, 2017-03-21 18:28:26]

OWNERS lgtm.

[Jay Civelli, 2017-03-21 18:33:53]

The CQ bit was checked by jcivelli@chromium.org

[Jay Civelli, 2017-03-21 18:33:54]

The patchset sent to the CQ was uploaded after l-g-t-m from boliu@chromium.org,
agrieve@chromium.org
Link to the patchset: https://codereview.chromium.org/2765453004/#ps120001
(title: "Synced")

[commit-bot: I haz the power, 2017-03-21 18:34:24]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-21 18:46:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-21 18:46:09]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Jay Civelli, 2017-03-21 18:51:46]

The CQ bit was checked by jcivelli@chromium.org

[Jay Civelli, 2017-03-21 18:51:47]

The patchset sent to the CQ was uploaded after l-g-t-m from tsepez@chromium.org,
jbudorick@chromium.org, boliu@chromium.org, agrieve@chromium.org
Link to the patchset: https://codereview.chromium.org/2765453004/#ps140001
(title: "Added missing OWNERS file.")

[commit-bot: I haz the power, 2017-03-21 18:52:15]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-21 19:26:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-21 19:26:50]

Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[Jay Civelli, 2017-03-21 20:00:51]

The CQ bit was checked by jcivelli@chromium.org

[commit-bot: I haz the power, 2017-03-21 20:01:11]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-21 20:36:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-21 20:36:11]

Failed to apply patch for
content/public/android/java/src/org/chromium/content/browser/ChildProcessConnection.java:
While running git apply --index -p1;
  error: patch failed:
content/public/android/java/src/org/chromium/content/browser/ChildProcessConnection.java:7
  error:
content/public/android/java/src/org/chromium/content/browser/ChildProcessConnection.java:
patch does not apply

Patch:      
content/public/android/java/src/org/chromium/content/browser/ChildProcessConnection.java
Index:
content/public/android/java/src/org/chromium/content/browser/ChildProcessConnection.java
diff --git
a/content/public/android/java/src/org/chromium/content/browser/ChildProcessConnection.java
b/content/public/android/java/src/org/chromium/content/browser/ChildProcessConnection.java
index
5e786a6c7302c2b6817d832a0d04589f96f87542..21270655f6170fb4a5c0a6ed6b78456880932153
100644
---
a/content/public/android/java/src/org/chromium/content/browser/ChildProcessConnection.java
+++
b/content/public/android/java/src/org/chromium/content/browser/ChildProcessConnection.java
@@ -7,7 +7,7 @@ package org.chromium.content.browser;
 import android.os.Bundle;
 
 import org.chromium.base.process_launcher.ChildProcessCreationParams;
-import org.chromium.content.common.FileDescriptorInfo;
+import org.chromium.base.process_launcher.FileDescriptorInfo;
 import org.chromium.content.common.IChildProcessCallback;
 import org.chromium.content.common.IChildProcessService;

[Jay Civelli, 2017-03-21 20:39:34]

The CQ bit was checked by jcivelli@chromium.org

[Jay Civelli, 2017-03-21 20:39:35]

The patchset sent to the CQ was uploaded after l-g-t-m from tsepez@chromium.org,
jbudorick@chromium.org, boliu@chromium.org, agrieve@chromium.org
Link to the patchset: https://codereview.chromium.org/2765453004/#ps160001
(title: "Synced.")

[commit-bot: I haz the power, 2017-03-21 20:40:09]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-21 21:54:48]

CQ is committing da patch.

Bot data: {"patchset_id": 160001, "attempt_start_ts": 1490128774463870,
"parent_rev": "a0a1b3df67b6a958b8dd7007cc8edcae18a4d9bb", "commit_rev":
"d62ca1238e8c477dfbbbe928febfa67dd19bfe35"}

[commit-bot: I haz the power, 2017-03-21 21:55:44]

Description was changed from

==========
Moving FileDescriptorInfo from content/ to base/ and making base
multiprocess test client use this class (instead of their own version).

BUG=702316
==========

to

==========
Moving FileDescriptorInfo from content/ to base/ and making base
multiprocess test client use this class (instead of their own version).

BUG=702316

Review-Url: https://codereview.chromium.org/2765453004
Cr-Commit-Position: refs/heads/master@{#458568}
Committed:
https://chromium.googlesource.com/chromium/src/+/d62ca1238e8c477dfbbbe928febf...
==========

[commit-bot: I haz the power, 2017-03-21 21:55:46]

Committed patchset #5 (id:160001) as
https://chromium.googlesource.com/chromium/src/+/d62ca1238e8c477dfbbbe928febf...