content/public/android/java/src/org/chromium/content/browser/ChildProcessConnectionImpl.java - Issue 2765453004: Moving FileDescriptorInfo from content/ to base/.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/android/java/src/org/chromium/content/browser/ChildProcessConnectionImpl.java

Issue 2765453004: Moving FileDescriptorInfo from content/ to base/. (Closed)

Patch Set: Synced. Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/public/android/java/src/org/chromium/content/browser/ChildProcessConnection.java ('k') | content/public/android/java/src/org/chromium/content/browser/ChildProcessLauncher.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/public/android/java/src/org/chromium/content/browser/ChildProcessConnectionImpl.java

diff --git a/content/public/android/java/src/org/chromium/content/browser/ChildProcessConnectionImpl.java b/content/public/android/java/src/org/chromium/content/browser/ChildProcessConnectionImpl.java

index 4fdcd1cb2f1c0d54e02897e5d63b0233c6c68ccc..f6a0f8e7e82e468279d921c5bb60dee463fda10e 100644

--- a/content/public/android/java/src/org/chromium/content/browser/ChildProcessConnectionImpl.java

+++ b/content/public/android/java/src/org/chromium/content/browser/ChildProcessConnectionImpl.java

@@ -21,7 +21,7 @@ import org.chromium.base.ThreadUtils;

import org.chromium.base.TraceEvent;

import org.chromium.base.VisibleForTesting;

import org.chromium.base.process_launcher.ChildProcessCreationParams;

-import org.chromium.content.common.FileDescriptorInfo;

+import org.chromium.base.process_launcher.FileDescriptorInfo;

import org.chromium.content.common.IChildProcessCallback;

import org.chromium.content.common.IChildProcessService;

@@ -410,7 +410,7 @@ public class ChildProcessConnectionImpl implements ChildProcessConnection {

// We proactively close the FDs rather than wait for GC & finalizer.

try {

for (FileDescriptorInfo fileInfo : mConnectionParams.mFilesToBeMapped) {

- fileInfo.mFd.close();

+ fileInfo.fd.close();

}

} catch (IOException ioe) {

Log.w(TAG, "Failed to close FD.", ioe);