chrome/browser/chromeos/policy/configuration_policy_handler_chromeos_unittest.cc - Issue 2765363004: Stop passing raw pointers to DictionaryValue::Set, part 2

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/policy/configuration_policy_handler_chromeos_unittest.cc

Issue 2765363004: Stop passing raw pointers to DictionaryValue::Set, part 2 (Closed)

Patch Set: Fix comments Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/policy/auto_enrollment_client.cc ('k') | chrome/browser/chromeos/policy/remote_commands/device_command_screenshot_job_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/policy/configuration_policy_handler_chromeos_unittest.cc

diff --git a/chrome/browser/chromeos/policy/configuration_policy_handler_chromeos_unittest.cc b/chrome/browser/chromeos/policy/configuration_policy_handler_chromeos_unittest.cc

index 3639151f174ac71ef343c81b57cef5e25f099348..60aa9525d1915dc9e45ebfd7840587414ae70278 100644

--- a/chrome/browser/chromeos/policy/configuration_policy_handler_chromeos_unittest.cc

+++ b/chrome/browser/chromeos/policy/configuration_policy_handler_chromeos_unittest.cc

@@ -319,7 +319,8 @@ TEST(PinnedLauncherAppsPolicyHandler, PrefTranslation) {

base::Value entry1("abcdefghijklmnopabcdefghijklmnop");

auto entry1_dict = base::MakeUnique<base::DictionaryValue>();

- entry1_dict->Set(ash::launcher::kPinnedAppsPrefAppIDPath, entry1.DeepCopy());

+ entry1_dict->Set(ash::launcher::kPinnedAppsPrefAppIDPath,

+ entry1.CreateDeepCopy());

expected_pinned_apps.Append(std::move(entry1_dict));

list.Append(entry1.CreateDeepCopy());

policy_map.Set(key::kPinnedLauncherApps, POLICY_LEVEL_MANDATORY,