chrome/browser/chromeos/policy/remote_commands/device_command_screenshot_job_unittest.cc - Issue 2765363004: Stop passing raw pointers to DictionaryValue::Set, part 2

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/policy/remote_commands/device_command_screenshot_job_unittest.cc

Issue 2765363004: Stop passing raw pointers to DictionaryValue::Set, part 2 (Closed)

Patch Set: Fix comments Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/policy/configuration_policy_handler_chromeos_unittest.cc ('k') | chrome/browser/chromeos/proxy_cros_settings_parser.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/policy/remote_commands/device_command_screenshot_job_unittest.cc

diff --git a/chrome/browser/chromeos/policy/remote_commands/device_command_screenshot_job_unittest.cc b/chrome/browser/chromeos/policy/remote_commands/device_command_screenshot_job_unittest.cc

index db444aee085d00c6e463d4781cb8c8e4f49b65d9..574f5380de1c14e48a9201346a78537080f148ef 100644

--- a/chrome/browser/chromeos/policy/remote_commands/device_command_screenshot_job_unittest.cc

+++ b/chrome/browser/chromeos/policy/remote_commands/device_command_screenshot_job_unittest.cc

@@ -247,7 +247,7 @@ std::string DeviceCommandScreenshotTest::CreatePayloadFromResultCode(

std::string payload;

base::DictionaryValue root_dict;

if (result_code != DeviceCommandScreenshotJob::SUCCESS)

- root_dict.Set(kResultFieldName, new base::Value(result_code));

+ root_dict.Set(kResultFieldName, base::MakeUnique<base::Value>(result_code));

base::JSONWriter::Write(root_dict, &payload);

return payload;

}