Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(418)

Side by Side Diff: chrome/browser/chromeos/policy/configuration_policy_handler_chromeos_unittest.cc

Issue 2765363004: Stop passing raw pointers to DictionaryValue::Set, part 2 (Closed)
Patch Set: Fix comments Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/chromeos/policy/configuration_policy_handler_chromeos.h " 5 #include "chrome/browser/chromeos/policy/configuration_policy_handler_chromeos.h "
6 6
7 #include <memory> 7 #include <memory>
8 #include <utility> 8 #include <utility>
9 9
10 #include "base/callback.h" 10 #include "base/callback.h"
(...skipping 301 matching lines...) Expand 10 before | Expand all | Expand 10 after
312 312
313 policy_map.Set(key::kPinnedLauncherApps, POLICY_LEVEL_MANDATORY, 313 policy_map.Set(key::kPinnedLauncherApps, POLICY_LEVEL_MANDATORY,
314 POLICY_SCOPE_USER, POLICY_SOURCE_CLOUD, list.CreateDeepCopy(), 314 POLICY_SCOPE_USER, POLICY_SOURCE_CLOUD, list.CreateDeepCopy(),
315 nullptr); 315 nullptr);
316 handler.ApplyPolicySettings(policy_map, &prefs); 316 handler.ApplyPolicySettings(policy_map, &prefs);
317 EXPECT_TRUE(prefs.GetValue(prefs::kPolicyPinnedLauncherApps, &value)); 317 EXPECT_TRUE(prefs.GetValue(prefs::kPolicyPinnedLauncherApps, &value));
318 EXPECT_TRUE(base::Value::Equals(&expected_pinned_apps, value)); 318 EXPECT_TRUE(base::Value::Equals(&expected_pinned_apps, value));
319 319
320 base::Value entry1("abcdefghijklmnopabcdefghijklmnop"); 320 base::Value entry1("abcdefghijklmnopabcdefghijklmnop");
321 auto entry1_dict = base::MakeUnique<base::DictionaryValue>(); 321 auto entry1_dict = base::MakeUnique<base::DictionaryValue>();
322 entry1_dict->Set(ash::launcher::kPinnedAppsPrefAppIDPath, entry1.DeepCopy()); 322 entry1_dict->Set(ash::launcher::kPinnedAppsPrefAppIDPath,
323 entry1.CreateDeepCopy());
323 expected_pinned_apps.Append(std::move(entry1_dict)); 324 expected_pinned_apps.Append(std::move(entry1_dict));
324 list.Append(entry1.CreateDeepCopy()); 325 list.Append(entry1.CreateDeepCopy());
325 policy_map.Set(key::kPinnedLauncherApps, POLICY_LEVEL_MANDATORY, 326 policy_map.Set(key::kPinnedLauncherApps, POLICY_LEVEL_MANDATORY,
326 POLICY_SCOPE_USER, POLICY_SOURCE_CLOUD, list.CreateDeepCopy(), 327 POLICY_SCOPE_USER, POLICY_SOURCE_CLOUD, list.CreateDeepCopy(),
327 nullptr); 328 nullptr);
328 prefs.Clear(); 329 prefs.Clear();
329 handler.ApplyPolicySettings(policy_map, &prefs); 330 handler.ApplyPolicySettings(policy_map, &prefs);
330 EXPECT_TRUE(prefs.GetValue(prefs::kPolicyPinnedLauncherApps, &value)); 331 EXPECT_TRUE(prefs.GetValue(prefs::kPolicyPinnedLauncherApps, &value));
331 EXPECT_TRUE(base::Value::Equals(&expected_pinned_apps, value)); 332 EXPECT_TRUE(base::Value::Equals(&expected_pinned_apps, value));
332 } 333 }
(...skipping 24 matching lines...) Expand all
357 POLICY_SCOPE_USER, POLICY_SOURCE_CLOUD, 358 POLICY_SCOPE_USER, POLICY_SOURCE_CLOUD,
358 base::MakeUnique<base::Value>(false), nullptr); 359 base::MakeUnique<base::Value>(false), nullptr);
359 LoginScreenPowerManagementPolicyHandler handler(chrome_schema_); 360 LoginScreenPowerManagementPolicyHandler handler(chrome_schema_);
360 PolicyErrorMap errors; 361 PolicyErrorMap errors;
361 EXPECT_FALSE(handler.CheckPolicySettings(policy_map, &errors)); 362 EXPECT_FALSE(handler.CheckPolicySettings(policy_map, &errors));
362 EXPECT_FALSE( 363 EXPECT_FALSE(
363 errors.GetErrors(key::kDeviceLoginScreenPowerManagement).empty()); 364 errors.GetErrors(key::kDeviceLoginScreenPowerManagement).empty());
364 } 365 }
365 366
366 } // namespace policy 367 } // namespace policy
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698