chrome/browser/chromeos/extensions/info_private_api.h - Issue 2765363004: Stop passing raw pointers to DictionaryValue::Set, part 2

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/extensions/info_private_api.h

Issue 2765363004: Stop passing raw pointers to DictionaryValue::Set, part 2 (Closed)

Patch Set: Fix comments Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/chromeos/extensions/info_private_api.h

diff --git a/chrome/browser/chromeos/extensions/info_private_api.h b/chrome/browser/chromeos/extensions/info_private_api.h

index c7e497aec352e2488b4feca956218404e8d81290..9ea71b5fa54c07cc60622f37dd6d6f54822df1b4 100644

--- a/chrome/browser/chromeos/extensions/info_private_api.h

+++ b/chrome/browser/chromeos/extensions/info_private_api.h

@@ -27,7 +27,7 @@ class ChromeosInfoPrivateGetFunction : public AsyncExtensionFunction {

private:

// Returns a newly allocate value, or null.

- base::Value* GetValue(const std::string& property_name);

+ std::unique_ptr<base::Value> GetValue(const std::string& property_name);

// Gets boolean |pref| value from PrefService.

bool GetBooleanPrefValue(const char* pref);