Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Side by Side Diff: chrome/browser/chromeos/extensions/info_private_api.h

Issue 2765363004: Stop passing raw pointers to DictionaryValue::Set, part 2 (Closed)
Patch Set: Fix comments Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_CHROMEOS_EXTENSIONS_INFO_PRIVATE_API_H_ 5 #ifndef CHROME_BROWSER_CHROMEOS_EXTENSIONS_INFO_PRIVATE_API_H_
6 #define CHROME_BROWSER_CHROMEOS_EXTENSIONS_INFO_PRIVATE_API_H_ 6 #define CHROME_BROWSER_CHROMEOS_EXTENSIONS_INFO_PRIVATE_API_H_
7 7
8 #include <string> 8 #include <string>
9 9
10 #include "base/compiler_specific.h" 10 #include "base/compiler_specific.h"
11 #include "extensions/browser/extension_function.h" 11 #include "extensions/browser/extension_function.h"
12 12
13 namespace base { 13 namespace base {
14 class Value; 14 class Value;
15 } 15 }
16 16
17 namespace extensions { 17 namespace extensions {
18 18
19 class ChromeosInfoPrivateGetFunction : public AsyncExtensionFunction { 19 class ChromeosInfoPrivateGetFunction : public AsyncExtensionFunction {
20 public: 20 public:
21 ChromeosInfoPrivateGetFunction(); 21 ChromeosInfoPrivateGetFunction();
22 22
23 protected: 23 protected:
24 ~ChromeosInfoPrivateGetFunction() override; 24 ~ChromeosInfoPrivateGetFunction() override;
25 25
26 bool RunAsync() override; 26 bool RunAsync() override;
27 27
28 private: 28 private:
29 // Returns a newly allocate value, or null. 29 // Returns a newly allocate value, or null.
30 base::Value* GetValue(const std::string& property_name); 30 std::unique_ptr<base::Value> GetValue(const std::string& property_name);
31 31
32 // Gets boolean |pref| value from PrefService. 32 // Gets boolean |pref| value from PrefService.
33 bool GetBooleanPrefValue(const char* pref); 33 bool GetBooleanPrefValue(const char* pref);
34 34
35 DECLARE_EXTENSION_FUNCTION("chromeosInfoPrivate.get", CHROMEOSINFOPRIVATE_GET) 35 DECLARE_EXTENSION_FUNCTION("chromeosInfoPrivate.get", CHROMEOSINFOPRIVATE_GET)
36 }; 36 };
37 37
38 class ChromeosInfoPrivateSetFunction : public UIThreadExtensionFunction { 38 class ChromeosInfoPrivateSetFunction : public UIThreadExtensionFunction {
39 public: 39 public:
40 ChromeosInfoPrivateSetFunction(); 40 ChromeosInfoPrivateSetFunction();
41 41
42 protected: 42 protected:
43 ~ChromeosInfoPrivateSetFunction() override; 43 ~ChromeosInfoPrivateSetFunction() override;
44 44
45 ResponseAction Run() override; 45 ResponseAction Run() override;
46 46
47 private: 47 private:
48 DECLARE_EXTENSION_FUNCTION("chromeosInfoPrivate.set", CHROMEOSINFOPRIVATE_SET) 48 DECLARE_EXTENSION_FUNCTION("chromeosInfoPrivate.set", CHROMEOSINFOPRIVATE_SET)
49 }; 49 };
50 50
51 51
52 } // namespace extensions 52 } // namespace extensions
53 53
54 #endif // CHROME_BROWSER_CHROMEOS_EXTENSIONS_INFO_PRIVATE_API_H_ 54 #endif // CHROME_BROWSER_CHROMEOS_EXTENSIONS_INFO_PRIVATE_API_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698